Re: KPixmapCache in kdelibs4support uses QDateTime in mmap'ed struct

2015-11-05 Thread David Faure
On Tuesday 03 November 2015 11:06:00 Alex Merry wrote: > On 2015-11-03 00:56, Michael Pyne wrote: > > On Tue, November 3, 2015 00:40:58 Albert Astals Cid wrote: > >> Someone went a bit too far in the "port away from time_t to QDateTime" > >> and > >> changed the timestamp member of the KPixmapCach

Re: KPixmapCache in kdelibs4support uses QDateTime in mmap'ed struct

2015-11-03 Thread Alex Merry
On 2015-11-03 00:56, Michael Pyne wrote: On Tue, November 3, 2015 00:40:58 Albert Astals Cid wrote: Someone went a bit too far in the "port away from time_t to QDateTime" and changed the timestamp member of the KPixmapCacheIndexHeader struct. According to mpyne and thiago this is a big no-no.

Re: KPixmapCache in kdelibs4support uses QDateTime in mmap'ed struct

2015-11-02 Thread Michael Pyne
On Tue, November 3, 2015 00:40:58 Albert Astals Cid wrote: > Someone went a bit too far in the "port away from time_t to QDateTime" and > changed the timestamp member of the KPixmapCacheIndexHeader struct. > > According to mpyne and thiago this is a big no-no. The reason it's a big no-no is becau

KPixmapCache in kdelibs4support uses QDateTime in mmap'ed struct

2015-11-02 Thread Albert Astals Cid
Someone went a bit too far in the "port away from time_t to QDateTime" and changed the timestamp member of the KPixmapCacheIndexHeader struct. According to mpyne and thiago this is a big no-no. I'm suggesting bringing the code back to using time_t so it still works, this may be a bit less porta