D24439: Fix test kfileplacesmodeltest after D7446

meven added a comment. Fixed as of https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/250/ REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24439 To: meven, dfaure, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, micha

D24439: Fix test kfileplacesmodeltest after D7446

This revision was automatically updated to reflect the committed changes. Closed by commit R241:6d8bd6f99a1c: Fix test kfileplacesmodeltest after D7446 (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24439?vs=67369&id=67384 REVISION DE

D24439: Fix test kfileplacesmodeltest after D7446

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24439 To: meven, dfaure, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24439: Fix test kfileplacesmodeltest after D7446

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24439 To: meven, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24439: Fix test kfileplacesmodeltest after D7446

meven created this revision. meven added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY See D7556 REPOSITORY R241 KIO BRANCH master REVIS

D13018: Fix unit test for kfileplacesmodeltest

This revision was automatically updated to reflect the committed changes. Closed by commit R241:2c478f4e429b: Fix unit test for kfileplacesmodeltest (authored by Renato Araujo Oliveira Filho <renato.ara...@kdab.com>). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.k

D13018: Fix unit test for kfileplacesmodeltest

renatoo added a comment. In D13018#266694 , @bruns wrote: > Shouldn't this be handled by: > http://doc.qt.io/qt-5/qstandardpaths.html#setTestModeEnabled this is different "setTestModeEnabled" sets the XDG_* dirs but the KIO tests expec

D13018: Fix unit test for kfileplacesmodeltest

bruns added a comment. Shouldn't this be handled by: http://doc.qt.io/qt-5/qstandardpaths.html#setTestModeEnabled REVISION DETAIL https://phabricator.kde.org/D13018 To: renatoo, ngraham Cc: bruns, ngraham, maximilianocuria, elvisangelaccio, kde-frameworks-devel, michaelh

D13018: Fix unit test for kfileplacesmodeltest

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better, thanks for indulging me. :) Now onto `kfileplacesviewtest`... REVISION DETAIL https://phabricator.kde.org/D13018 To: renatoo, ngraham Cc: ngraham, maximilianocuria, el

D13018: Fix unit test for kfileplacesmodeltest

renatoo added a comment. In D13018#266626 , @ngraham wrote: > I know you didn't change that, but it might be a nice enhancement (hint hint). :) In D13018#266626 , @ngraham wrote: > I k

D13018: Fix unit test for kfileplacesmodeltest

renatoo updated this revision to Diff 34666. renatoo added a comment. Run tests in an empty home dir CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13018?vs=34646&id=34666 REVISION DETAIL https://phabricator.kde.org/D13018 AFFECTED FILES autotests/kfileplacesmodeltest.cpp To:

D13018: Fix unit test for kfileplacesmodeltest

ngraham added a comment. I know you didn't change that, but it might be a nice enhancement (hint hint). :) REVISION DETAIL https://phabricator.kde.org/D13018 To: renatoo, ngraham Cc: ngraham, maximilianocuria, elvisangelaccio, kde-frameworks-devel, michaelh, bruns

D13018: Fix unit test for kfileplacesmodeltest

renatoo added a comment. In D13018#266623 , @ngraham wrote: > Shouldn't that be a part of the test itself? I don't think it's reasonable to require that testers and testing platforms manually run that every time. I am not sure, this is ho

D13018: Fix unit test for kfileplacesmodeltest

ngraham added a comment. Shouldn't that be a part of the test itself? I don't think it's reasonable to require that testers and testing platforms manually run that every time. REVISION DETAIL https://phabricator.kde.org/D13018 To: renatoo, ngraham Cc: ngraham, maximilianocuria, elvisangela

D13018: Fix unit test for kfileplacesmodeltest

renatoo added a comment. as maximilianocuria said, before run the tests you need to create a temporary home path: HOMETMP=$(mktemp -d) trap 'rm -rf $HOMETMP' EXIT export HOME="$HOMETMP" REVISION DETAIL https://phabricator.kde.org/D13018 To: renatoo, ngraham Cc: ngraham, maximilian

D13018: Fix unit test for kfileplacesmodeltest

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. `kiofilewidgets-kfileplacesmodeltest` still fails for me with this patch: grep 'FAIL! : KFilePlacesModelTest' -A 3 Testing/Temporary/LastTest.log

D13018: Fix unit test for kfileplacesmodeltest

renatoo added a comment. ok it should work now. REVISION DETAIL https://phabricator.kde.org/D13018 To: renatoo Cc: maximilianocuria, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D13018: Fix unit test for kfileplacesmodeltest

renatoo updated this revision to Diff 34646. renatoo added a comment. Fixed code style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13018?vs=34645&id=34646 REVISION DETAIL https://phabricator.kde.org/D13018 AFFECTED FILES autotests/kfileplacesmodeltest.cpp To: renatoo Cc: ma

D13018: Fix unit test for kfileplacesmodeltest

renatoo updated this revision to Diff 34645. renatoo added a comment. Fixed all tests CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13018?vs=34644&id=34645 REVISION DETAIL https://phabricator.kde.org/D13018 AFFECTED FILES autotests/kfileplacesmodeltest.cpp To: renatoo Cc: max

D13018: Fix unit test for kfileplacesmodeltest

renatoo updated this revision to Diff 34644. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13018?vs=34581&id=34644 REVISION DETAIL https://phabricator.kde.org/D13018 AFFECTED FILES autotests/kfileplacesmodeltest.cpp To: renatoo Cc: maximilianocuria, elvisangelaccio, kde-framework

D13018: Fix unit test for kfileplacesmodeltest

maximilianocuria added a comment. In D13018#266137 <https://phabricator.kde.org/D13018#266137>, @elvisangelaccio wrote: > Hmm, still seems to fail here: > > $ ctest -R kfileplacesmodeltest > Test project /home/elvis/dev/kde/kio/local-build > Sta

D13018: Fix unit test for kfileplacesmodeltest

elvisangelaccio added a comment. Hmm, still seems to fail here: $ ctest -R kfileplacesmodeltest Test project /home/elvis/dev/kde/kio/local-build Start 50: kiofilewidgets-kfileplacesmodeltest 1/1 Test #50: kiofilewidgets-kfileplacesmodeltest ...***Failed0.60 sec

D13018: Fix unit test for kfileplacesmodeltest

renatoo updated this revision to Diff 34581. renatoo added a comment. Add missing url REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13018?vs=34580&id=34581 REVISION DETAIL https://phabricator.kde.org/D13018 AFFECTED FILES autotests/kfileplacesmodeltest.c

D13018: Fix unit test for kfileplacesmodeltest

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. renatoo requested review of this revision. TEST PLAN Run "kiofilewidgets-kfileplacesmodeltest" make sure that "testRemoteUr

D8366: Factoring out lists of url data within KFilePlacesModelTest

dfaure added inline comments. INLINE COMMENTS > kfileplacesmodeltest.cpp:966 > QTest::newRow("Places - Trash") << m_places->index(2, 0) > - << QStringLiteral("user-trash-full"); > + << QStringLiteral("user-trash"); > QT

D8366: Factoring out lists of url data within KFilePlacesModelTest

This revision was automatically updated to reflect the committed changes. Closed by commit R241:3e537c4dd935: Factoring out lists of url data within KFilePlacesModelTest (authored by franckarrecot, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https

D9017: Avoid run kfileplacesmodeltest and kfileplacesviewtest in parallel

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Both tests modify the bookmark file and that can cause test failure TEST PLAN run all kio unit test REPOSITORY R241 KIO BRANCH seria

D9017: Avoid run kfileplacesmodeltest and kfileplacesviewtest in parallel

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH serialize-unit-test REVISION DETAIL https://phabricator.kde.org/D9017 To: renatoo, dfaure Cc: #frameworks

D8366: Factoring out lists of url data within KFilePlacesModelTest

franckarrecot updated this revision to Diff 23023. franckarrecot added a comment. update REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8366?vs=22900&id=23023 REVISION DETAIL https://phabricator.kde.org/D8366 AFFECTED FILES autotests/kfileplacesmodeltest.

D8366: Factoring out lists of url data within KFilePlacesModelTest

franckarrecot added a comment. this one is landable now that its dependencies are pushed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8366 To: franckarrecot, renatoo, ervin, mlaurent Cc: anthonyfieroni, ervin, ngraham, mlaurent, #frameworks

D9017: Avoid run kfileplacesmodeltest and kfileplacesviewtest in parallel

This revision was automatically updated to reflect the committed changes. Closed by commit R241:700c7d3af43b: Avoid run kfileplacesmodeltest and kfileplacesviewtest in parallel (authored by Renato Araujo Oliveira Filho <renato.ara...@kdab.com>). REPOSITORY R241 KIO CHANGES SINCE LAST

D8366: Factoring out lists of url data within KFilePlacesModelTest

franckarrecot added a comment. I'll ship it as soon as the commits it's built on will be shipped. Sorry I rebased this one to renato new commit split so we would avoid conflict if interlaced commit pushed happend. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8366 To

D8366: Factoring out lists of url data within KFilePlacesModelTest

franckarrecot edited the summary of this revision. franckarrecot added a dependency: D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8366 To: franckarrecot, renatoo, ervin, mlaurent Cc: anthonyfieroni, ervi

D8366: Factoring out lists of url data within KFilePlacesModelTest

anthonyfieroni added a comment. Ship it, it's only tests and looks good. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8366 To: franckarrecot, renatoo, ervin, mlaurent Cc: anthonyfieroni, ervin, ngraham, mlaurent, #frameworks

D8366: Factoring out lists of url data within KFilePlacesModelTest

ngraham added a comment. Is this ready to go in, or do we need some more time for review? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8366 To: franckarrecot, renatoo, ervin, mlaurent Cc: ervin, ngraham, mlaurent, #frameworks

D8366: Factoring out lists of url data within KFilePlacesModelTest

franckarrecot updated this revision to Diff 22900. franckarrecot added a comment. rebased over in review renato 's patches REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8366?vs=21750&id=22900 REVISION DETAIL https://phabricator.kde.org/D8366 AFFECTED FILES

D8366: Factoring out lists of url data within KFilePlacesModelTest

franckarrecot commandeered this revision. franckarrecot edited reviewers, added: mlaurent; removed: franckarrecot. REVISION DETAIL https://phabricator.kde.org/D8366 To: franckarrecot, renatoo, ervin, mlaurent Cc: ervin, ngraham, mlaurent, #frameworks

D8366: Factoring out lists of url data within KFilePlacesModelTest

renatoo added a comment. In https://phabricator.kde.org/D8366#163427, @ngraham wrote: > Is this dependent on any of the other patches floating around? Probably not, but that will affect (possible conflicts) with all patches REVISION DETAIL https://phabricator.kde.org/D8366 To:

D8366: Factoring out lists of url data within KFilePlacesModelTest

ngraham added a comment. Is this dependent on any of the other patches floating around? REVISION DETAIL https://phabricator.kde.org/D8366 To: mlaurent, renatoo, ervin, franckarrecot Cc: ervin, ngraham, mlaurent, #frameworks

D8366: Factoring out lists of url data within KFilePlacesModelTest

renatoo accepted this revision. REVISION DETAIL https://phabricator.kde.org/D8366 To: mlaurent, renatoo, ervin, franckarrecot Cc: ervin, ngraham, mlaurent, #frameworks

D8366: Factoring out lists of url data within KFilePlacesModelTest

ervin accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D8366 To: mlaurent, renatoo, ervin, franckarrecot Cc: ervin, ngraham, mlaurent, #frameworks

D8366: Factoring out lists of url data within KFilePlacesModelTest

mlaurent updated this revision to Diff 21750. mlaurent added a comment. Rebase it CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8366?vs=21646&id=21750 REVISION DETAIL https://phabricator.kde.org/D8366 AFFECTED FILES autotests/kfileplacesmodeltest.cpp To: mlaurent, renatoo, er

D8366: Factoring out lists of url data within KFilePlacesModelTest

mlaurent updated this revision to Diff 21646. mlaurent added a comment. Fix typo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8366?vs=21289&id=21646 REVISION DETAIL https://phabricator.kde.org/D8366 AFFECTED FILES autotests/kfileplacesmodeltest.cpp To: mlaurent, renatoo, erv

D8366: Factoring out lists of url data within KFilePlacesModelTest

mlaurent commandeered this revision. mlaurent edited reviewers, added: franckarrecot; removed: mlaurent. mlaurent added a comment. impossible to rebase this one... I will need to rewrite all this patch REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8366 To: mlaurent,

D8366: Factoring out lists of url data within KFilePlacesModelTest

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfileplacesmodeltest.cpp:177 > > +static const QStringList initalListOfPlaces() > +{ Typo: initial > kfileplacesmodeltest.cpp:182 > + > +static const QString

D8366: Factoring out lists of url data within KFilePlacesModelTest

mlaurent added a dependent revision: D8367: Hidding place groups implementation in KFilePlacesModel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8366 To: franckarrecot, renatoo, mlaurent Cc: mlaurent, #frameworks

D8366: Factoring out lists of url data within KFilePlacesModelTest

franckarrecot updated this revision to Diff 21289. franckarrecot added a comment. switch removable after regular devices REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8366?vs=20973&id=21289 REVISION DETAIL https://phabricator.kde.org/D8366 AFFECTED FILES

D8366: Factoring out lists of url data within KFilePlacesModelTest

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. seems ok for me REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8366 To: franckarrecot, renatoo, mlaurent Cc: mlaurent, #frameworks

D8366: Factoring out lists of url data within KFilePlacesModelTest

franckarrecot created this revision. franckarrecot added a reviewer: renatoo. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Instead of reusing the same string lists all over the place we factor them out, easier to re

Re: KFilePlacesModelTest

On Saturday 07 May 2016 19:50:36 Michael Pyne wrote: > On Sat, May 7, 2016 14:33:53 David Faure wrote: > > The thing I wonder is... does it really make sense to have a model with > > random ordering? Isn't it a problem for users if their visible list of > > places is different between every run? Or

Re: KFilePlacesModelTest

Il 07/05/2016 20:05, David Faure ha scritto: We disable seed randomisation and sse4.2 (can't remember why that mattered, that was something Volker found out iirc), and that made it pass until recently, I'm not sure what changed. Isn't that inherently dangerous though? Even with those disabled,

Re: KFilePlacesModelTest

Il 07/05/2016 14:33, David Faure ha scritto: The thing I wonder is... does it really make sense to have a model with random ordering? Isn't it a problem for users if their visible list of places is different between every run? Or am I missing something and the different order in the test isn't

Re: KFilePlacesModelTest

On Sat, May 7, 2016 14:33:53 David Faure wrote: > The thing I wonder is... does it really make sense to have a model with > random ordering? Isn't it a problem for users if their visible list of > places is different between every run? Or am I missing something and the > different order in the test

Re: KFilePlacesModelTest

Hello, Not sure I can be of any help anymore in that area, I've been way to remote from that code for years now. That said there's a couple of questions at the end I might be able to answer: On Saturday, 7 May 2016 14:33:53 CEST David Faure wrote: > The thing I wonder is... does it really make

Re: KFilePlacesModelTest

On Saturday 07 May 2016 19:03:17 Giuseppe D'Angelo wrote: > Il 07/05/2016 14:33, David Faure ha scritto: > > The thing I wonder is... does it really make sense to have a model with > > random ordering? > > Isn't it a problem for users if their visible list of places is different > > between every

Re: KFilePlacesModelTest

On Wednesday 08 July 2015 07:58:22 Kevin Ottens wrote: > > On Saturday 04 July 2015 22:24:50 David Faure wrote: > > CI says: > > > > 10:59:57 QDEBUG : KFilePlacesModelTest::testReparse() Expected: > > ("/home/jenkins", "remote:/", "/&q

Change in kio[master]: Update kfileplacesmodeltest to read the correct file, after ...

David Faure has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/485 Change subject: Update kfileplacesmodeltest to read the correct file, after e919daeb5 .. Update kfileplacesmodeltest to read the

Re: KFilePlacesModelTest

Hello, On Saturday 04 July 2015 22:24:50 David Faure wrote: > CI says: > > 10:59:57 QDEBUG : KFilePlacesModelTest::testReparse() Expected: > ("/home/jenkins", "remote:/", "/", "trash:/", "/media/nfs", "/foreign", >

KFilePlacesModelTest

CI says: 10:59:57 QDEBUG : KFilePlacesModelTest::testReparse() Expected: ("/home/jenkins", "remote:/", "/", "trash:/", "/media/nfs", "/foreign", "/media/XO-Y4", "/media/floppy0", "/media/cdrom", &qu