D9802: Avoid Dolphin crash

2018-01-10 Thread Michael Heidelbach
michaelh marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9802 To: michaelh, #dolphin, #frameworks Cc: akrutzler, ngraham, michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, alexeymin, genaxxx, emmanuelp

D9802: Avoid Dolphin crash

2018-01-10 Thread Andreas Krutzler
akrutzler added inline comments. INLINE COMMENTS > michaelh wrote in kcoredirlister.cpp:1233 > I'd like to ask for some help here. > Debugging in KDevelop, trying to step through the code: > it's not possible for me. Sometimes the debugger even crashed. > > - I checked for debugging symbols with

D9802: Avoid Dolphin crash

2018-01-10 Thread Michael Heidelbach
michaelh marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9802 To: michaelh, #dolphin, #frameworks Cc: akrutzler, ngraham, michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, alexeymin, genaxxx, emmanuelp

D9802: Avoid Dolphin crash

2018-01-10 Thread Michael Heidelbach
michaelh marked 3 inline comments as done. michaelh added inline comments. INLINE COMMENTS > akrutzler wrote in kcoredirlister.cpp:1233 > Yes, i would just comment this out :) Once you are done, undo the comment. I'd like to ask for some help here. Debugging in KDevelop, trying to step through t

D9802: Avoid Dolphin crash

2018-01-10 Thread Michael Heidelbach
michaelh abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9802 To: michaelh, #dolphin, #frameworks Cc: akrutzler, ngraham, michaelh, spoorun, navarromorales, isidorov, firef, andrebarros, alexeymin, genaxxx, emmanuelp

D9802: Avoid Dolphin crash

2018-01-10 Thread Andreas Krutzler
akrutzler added inline comments. INLINE COMMENTS > michaelh wrote in kcoredirlister.cpp:1233 > I'm working with kio right now. Is better to just comment it out for the time > being? Yes, i would just comment this out :) Once you are done, undo the comment. REPOSITORY R241 KIO REVISION DETAI

D9802: Avoid Dolphin crash

2018-01-10 Thread Michael Heidelbach
michaelh added inline comments. INLINE COMMENTS > akrutzler wrote in kcoredirlister.cpp:1233 > Q_ASSERT is just executed in debug builds. It wont crash in release builds. > Checkout https://doc-snapshots.qt.io/qt5-dev/qtglobal.html#Q_ASSERT I'm working with kio right now. Is better to just comme

D9802: Avoid Dolphin crash

2018-01-10 Thread Andreas Krutzler
akrutzler added inline comments. INLINE COMMENTS > kcoredirlister.cpp:1233 > > -Q_ASSERT(!name.isEmpty()); > if (name.isEmpty()) { Q_ASSERT is just executed in debug builds. It wont crash in release builds. Checkout https://doc-snapshots.qt.io/qt5-dev/qtglobal.html#Q_ASSERT R

D9802: Avoid Dolphin crash

2018-01-10 Thread Nathaniel Graham
ngraham added a comment. Hmm, I can't reproduce the crash with Dolphin and KIO from git master. `dolphin tags:/Genre/Drama/` (after created a nested tag Genre/Drama) works fine for me. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9802 To: michaelh, #dolphin, #framew

D9802: Avoid Dolphin crash

2018-01-10 Thread Michael Heidelbach
michaelh created this revision. michaelh added reviewers: Dolphin, Frameworks. michaelh added projects: Dolphin, Frameworks, KDE Applications. michaelh requested review of this revision. REVISION SUMMARY Removed Q_ASSERT TEST PLAN $ dolphin tags:/Genre/Drama/ REPOSITORY R241 KIO BRANCH

D9802: Avoid Dolphin crash

2018-01-10 Thread Michael Heidelbach
michaelh added a comment. Reason: dolphin crashes when navigation to a nested tag e.g. tags:/Genre/Drama/ REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9802 To: michaelh, #dolphin, #frameworks Cc: ngraham, michaelh, spoorun, navarromorales, isidorov, firef, an