kossebau added a comment.
@broulik Seems to miss some include with Qt 5.7? build fails now on CI in
the patched code:
https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20SUSEQt5.7/15/
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D9312
To: brouli
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:5c9eab26ad7b: [ConfigPropertyMap] Don't emit
valueChanged on initial creation (authored by broulik).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9312?vs=238
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D9312
To: broulik, #plasma, hein
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas,
broulik added a comment.
Ping
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D9312
To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
broulik edited the test plan for this revision.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D9312
To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
We initially populate the `QQmlPropertyMap` with all keys in settings after
which the