dhaumann abandoned this revision.
dhaumann added a comment.
Abandoned in favor of followup request: https://phabricator.kde.org/D9393
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D9257
To: dhaumann, cullmann, neundorf
Cc: #frameworks, kevinapavew, ngraham, demsk
cullmann added a comment.
I like the code better with the array ;=)
I would use the enum values instead of 5 or 2, otherwise this is fine for me.
For the actual functionality I guess Alex should say yes/no.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D925
dhaumann added a comment.
ping?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D9257
To: dhaumann, cullmann, neundorf
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
dhaumann updated this revision to Diff 23782.
dhaumann added a comment.
- Honor spacing for message widgets
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9257?vs=23781&id=23782
BRANCH
MessageInterface (branched from master)
REVISION DETAIL
https:/
dhaumann updated this revision to Diff 23781.
dhaumann added a comment.
- Remove unneeded include
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9257?vs=23780&id=23781
BRANCH
MessageInterface (branched from master)
REVISION DETAIL
https://phabricat
dhaumann updated this revision to Diff 23780.
dhaumann added a comment.
- Simplify MessageWidget member variable handling
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9257?vs=23655&id=23780
BRANCH
MessageInterface (branched from master)
REVISION DE
cullmann added a comment.
For the "KateMessageWidget *m_topMessageWidget" and Co. members: Would it
make sense to have just an array of pointers with index == the matching
MessagePosition enum value?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D9257
To: dhaum
dhaumann created this revision.
dhaumann added reviewers: cullmann, neundorf.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This patch extends the message interface to support CenterInView.
This should be binary
