This revision was automatically updated to reflect the committed changes.
Closed by commit R242:604aba0e241f: reuse KPackage instance between
PluginLoader and Applet (authored by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9123?vs=
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
phab/kpackageinctor
REVISION DETAIL
https://phabricator.kde.org/D9123
To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks,
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in applet.cpp:98
> If anyone uses the old argument list syntax (where the first argument was a
> string or a kpluginmetadata) this will break.
>
> Can we be sure that the PluginLoader was the only user?
> It was a somewhat und
davidedmundson added inline comments.
INLINE COMMENTS
> applet.cpp:98
> : QObject(0),
> - d(new AppletPrivate(KPluginMetaData(), args.count() > 1 ?
> args[1].toInt() : 0, this))
> + d(new AppletPrivate(KPluginMetaData(), args.count() > 2 ?
> args[2].toInt() : 0, this))
> {
I
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
to minimize metadata lookups, pass the kpackage created in pluginloader
to the applet itsel
