D8983: Properly parse dates in cookies when running in non-English locale

2018-01-05 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8983 To: schwab, dfaure, #frameworks Cc: anthonyfieroni, #frameworks

D8983: Properly parse dates in cookies when running in non-English locale

2017-11-26 Thread David Faure
dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcookiejar.cpp:117 > > + // Only English month names are allowed, thus use the C locale. > +const QLocale cLocale = QLocale::c(); indentation seems strang

D8983: Properly parse dates in cookies when running in non-English locale

2017-11-26 Thread Andreas Schwab
schwab marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8983 To: schwab, dfaure, #frameworks Cc: anthonyfieroni, #frameworks

D8983: Properly parse dates in cookies when running in non-English locale

2017-11-26 Thread Andreas Schwab
schwab updated this revision to Diff 22971. schwab added a comment. Rename variable and constify. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8983?vs=22970&id=22971 REVISION DETAIL https://phabricator.kde.org/D8983 AFFECTED FILES src/ioslaves/http/kcoo

D8983: Properly parse dates in cookies when running in non-English locale

2017-11-26 Thread David Faure
dfaure added a comment. Thanks for the fix, looks good, just two minor improvement suggestions. INLINE COMMENTS > kcookiejar.cpp:78 > const QString weekday = value.left(index); > +QLocale l = QLocale::c(); > for (int i = 1; i < 8; ++i) { "i" and "l" local variables

D8983: Properly parse dates in cookies when running in non-English locale

2017-11-26 Thread Andreas Schwab
schwab marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8983 To: schwab, dfaure, #frameworks Cc: anthonyfieroni, #frameworks

D8983: Properly parse dates in cookies when running in non-English locale

2017-11-26 Thread Andreas Schwab
schwab updated this revision to Diff 22970. schwab added a comment. Use the week names from the C locale REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8983?vs=22882&id=22970 REVISION DETAIL https://phabricator.kde.org/D8983 AFFECTED FILES src/ioslaves/ht

D8983: Properly parse dates in cookies when running in non-English locale

2017-11-25 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > kcookiejar.cpp:78-84 > +static const char *const day_name[] = { > + "Mon", "Tue", "Wed", "Thu", "Fri", "Sat", "Sun" > +}; > +for (int i = 0; i < 7; ++i) { > +// No need to check for long names sin

D8983: Properly parse dates in cookies when running in non-English locale

2017-11-25 Thread Andreas Schwab
schwab added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8983 To: schwab, dfaure, #frameworks Cc: #frameworks

D8983: Properly parse dates in cookies when running in non-English locale

2017-11-24 Thread Andreas Schwab
schwab created this revision. schwab added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Use the C locale when parsing dates in cookies, since only English week and month names are allowed BU