emateli abandoned this revision.
emateli added a comment.
Resolved in https://phabricator.kde.org/D9217
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8920
To: emateli, #frameworks, dfaure
Cc: #frameworks
dfaure added inline comments.
INLINE COMMENTS
> kurlnavigator.cpp:1009
> +// Always expand starting ~/ to $HOME. We want all inputs starting with
> it to point home directory.
> +// The reason this expansion is performed here, is that kshorturifilter
> will not return the desired result
emateli updated this revision to Diff 23532.
emateli added a comment.
- ~/ at the start always resolves to $HOME
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8920?vs=22702&id=23532
BRANCH
relative-files-v2
REVISION DETAIL
https://phabricator.kde.org/D89
dfaure added a comment.
Sounds to me like ~/foo should always mean $HOME/foo even if that doesn't
exist.
INLINE COMMENTS
> kurlnavigatortest.cpp:207
> +
> +QTest::newRow("relativeFile") << QStringLiteral(".some_dotfile") <<
> QUrl::fromUserInput(".some_dotfile", QLatin1String(""),
> QU
emateli added a comment.
Ping. Thoughts on the last comment?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8920
To: emateli, #frameworks, dfaure
Cc: #frameworks
emateli added a comment.
@dfaure I've managed to take another look at this, added a `directory`
property which controls the base dir. Works as it should, however there is one
case where I'm not sure which way we want it and is probably just a matter of
preference.
User types `~/some-dir
dfaure added a comment.
Relative completions in KUrlCompletion defaults to $HOME but that can be
configured with KUrlCompletion::setDir.
Maybe KUrlNavigator should get a setter too, so that apps can set a base
directory that makes sense to them?
They have more context for setting a correc
emateli updated this revision to Diff 22702.
emateli added a comment.
- remove QDir::homePath + minor code style
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8920?vs=22671&id=22702
BRANCH
relative-files
REVISION DETAIL
https://phabricator.kde.org/D8920
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
I like the use of the 3-args QUrl::fromUserInput, I added it to Qt for such
purposes.
I don't like the hardcoded QDir::homePath(), this has to be done better...
In KUrlNavigato
elvisangelaccio added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8920
To: emateli, #frameworks, dfaure
Cc: #frameworks
emateli added a reviewer: Frameworks.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8920
To: emateli, #frameworks
Cc: #frameworks
emateli created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This patch aims to address an issue with KUrlNavigator using relative paths.
Upon attempting to navigate using relative paths, due to the wa
12 matches
Mail list logo
