D8774: Show Configure Toolbars dialog as modal

2019-12-05 Thread Nathaniel Graham
ngraham added a comment. Oops, sorry! I added comments to D8773 . REPOSITORY R263 KXmlGui BRANCH modal-toolbar-dialog REVISION DETAIL https://phabricator.kde.org/D8774 To: elvisangelaccio, #frameworks, dfaure Cc: kde-frameworks-devel, ngraham, LeGast

D8774: Show Configure Toolbars dialog as modal

2019-12-05 Thread David Faure
dfaure added a comment. The description says this depends on D8773 which isn't approved. REPOSITORY R263 KXmlGui BRANCH modal-toolbar-dialog REVISION DETAIL https://phabricator.kde.org/D8774 To: elvisangelaccio, #frameworks, dfaure Cc: kde-framewor

D8774: Show Configure Toolbars dialog as modal

2019-12-05 Thread Nathaniel Graham
ngraham added a comment. Herald added a subscriber: kde-frameworks-devel. Can this land? REPOSITORY R263 KXmlGui BRANCH modal-toolbar-dialog REVISION DETAIL https://phabricator.kde.org/D8774 To: elvisangelaccio, #frameworks, dfaure Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, m

D8774: Show Configure Toolbars dialog as modal

2017-11-12 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH modal-toolbar-dialog REVISION DETAIL https://phabricator.kde.org/D8774 To: elvisangelaccio, #frameworks, dfaure

D8774: Show Configure Toolbars dialog as modal

2017-11-12 Thread Elvis Angelaccio
elvisangelaccio edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8774 To: elvisangelaccio, #frameworks, dfaure

D8774: Show Configure Toolbars dialog as modal

2017-11-12 Thread Elvis Angelaccio
elvisangelaccio edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8774 To: elvisangelaccio, #frameworks, dfaure

D8774: Show Configure Toolbars dialog as modal

2017-11-12 Thread Elvis Angelaccio
elvisangelaccio edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D8774 To: elvisangelaccio, #frameworks, dfaure

D8774: Show Configure Toolbars dialog as modal

2017-11-12 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. REVISION SUMMARY The "Configure Toolbars" dialog was made non-modal a long time ago [1] in order to allow drag-and-drop of toolbar actions while the d