dhaumann added a comment.
@koichia For me, the unit tests pass. And it's also green on
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20XenialQt5.7/97/
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7861
To: koichia, dhaumann
Cc: d
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Thanks, closed with
https://cgit.kde.org/syntax-highlighting.git/commit/?id=2d5ee5629eb9638a56bae56e9210d5757fb7bafe
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://pha
dhaumann closed this revision.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7861
To: koichia, dhaumann
Cc: dhaumann, #frameworks, cullmann, vkrause
koichia updated this revision to Diff 19632.
koichia added a comment.
Hi,
I updated the patch.
However, some errors happen in clojure's test.
These errors also happened in the previous revision.
Start 1: appstreamtest
1/9 Test #1: appstreamtest
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
In general looks good, but 2 issues:
1. Please increase the version number in the lab xml element.
2. Please extend the unit test here:
https://github.com/KDE/syntax-hig
koichia edited the summary of this revision.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7861
To: koichia
Cc: #frameworks, cullmann, vkrause, dhaumann
koichia created this revision.
koichia added a project: Framework: Syntax Highlighting.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This change will fix clojure's syntax highlighting like the following code:
`(@
