D7840: Fix trailing space visualization for RTL lines.

2017-09-15 Thread Ben Cooksley
bcooksley added a comment. The hook doesn't cause the immediate closure of a diff. The hook asks Phabricator's background processes to initiate an update of the repository. When those commits are processed, the review gets closed. Depending on how busy Phabricator is processing other c

D7840: Fix trailing space visualization for RTL lines.

2017-09-15 Thread Safa Alfulaij
safaalfulaij added a comment. Sorry, my mistake. The post-commit trigger thing didn't close this, maybe because the #post part is there /me how come I didn't notice! :| https://cgit.kde.org/ktexteditor.git/commit/?id=bb328146ecd64f97710eb09f568001cd4d40f622 REPOSITORY R39 KTextEditor RE

D7840: Fix trailing space visualization for RTL lines.

2017-09-15 Thread Safa Alfulaij
This revision was automatically updated to reflect the committed changes. Closed by commit R39:bb328146ecd6: Fix trailing space visualization for RTL lines. (authored by safaalfulaij). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7840?vs=19564&id=19568 R

D7840: Fix trailing space visualization for RTL lines.

2017-09-15 Thread Safa Alfulaij
safaalfulaij added a comment. In https://phabricator.kde.org/D7840#146110, @kfunk wrote: > Indeed, thanks for those fixes. /me can see a nice blog post coming a long...? :) Not yet maybe There are other visualizations that are not working for RTL lines, like non-printable space

D7840: Fix trailing space visualization for RTL lines.

2017-09-15 Thread Kevin Funk
kfunk added a comment. Indeed, thanks for those fixes. /me can see a nice blog post coming a long...? :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7840 To: safaalfulaij, #ktexteditor, cullmann Cc: cullmann, kfunk, #frameworks, sars, dhaumann

D7840: Fix trailing space visualization for RTL lines.

2017-09-15 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. In deed, looks correct now and bogus before. Please commit. Could you perhaps add the link to this https://phabricator.kde.org/D7840 to the comment in the code? then we can eas

D7840: Fix trailing space visualization for RTL lines.

2017-09-15 Thread Safa Alfulaij
safaalfulaij added a comment. Before: F3912046: Screenshot_٢٠١٧٠٩١٥_١٧٥٣٥٦.png After: F3912047: Screenshot_٢٠١٧٠٩١٥_١٧٥٦٢٨.png REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7

D7840: Fix trailing space visualization for RTL lines.

2017-09-15 Thread Christoph Cullmann
cullmann added a comment. Yeah, +1 ;=) Without screeny, we can't judge. In any case: thanks for taking care! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7840 To: safaalfulaij, #ktexteditor Cc: cullmann, kfunk, #frameworks, sars, dhaumann

D7840: Fix trailing space visualization for RTL lines.

2017-09-15 Thread Kevin Funk
kfunk added a comment. Could you add before/after screenshots for this? I think this could also help non-RTL users understand what you're fixing. Would be super helpful for me at least :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7840 To: safaalfulaij,

D7840: Fix trailing space visualization for RTL lines.

2017-09-15 Thread Safa Alfulaij
safaalfulaij created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Fix trailing space visualization for RTL lines. It was getting paint on top of the character (to the right of the cursor). TEST