This revision was automatically updated to reflect the committed changes.
Closed by commit R127:16f4486cc54c: Update SurfaceInterface outputs when an
output global gets destroyed (authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7531?vs=18741&id=18804#toc
REPOS
graesslin added a comment.
Could you please push this change, it fixes a crash in KWin when changing
outputs (as discovered by PlasmaSurfaceTest::testOSDPlacement()):
Thread 1 "testPlasmaSurfa" received signal SIGSEGV, Segmentation fault.
KWayland::Server::OutputInterface::clientRes
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
mart/xdgforeign
REVISION DETAIL
https://phabricator.kde.org/D7531
To: davidedmundson, #plasma, graesslin
Cc: graesslin, anthonyfieroni, plasma-devel, #frameworks, leezu, Zren
davidedmundson updated this revision to Diff 18741.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
bleh
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7531?vs=18740&id=18741
BRANCH
mart/x
davidedmundson updated this revision to Diff 18740.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
Update connections better
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7531?vs=18725&id=1
graesslin added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in surface_interface.cpp:813
> UniqueConnection with lambda ?
Yeah, I don't think unique will work here. But looking at the code it also
doesn't matter if the lambda is executed multiple times.
REPOSITORY
R127 KWayland
anthonyfieroni added inline comments.
INLINE COMMENTS
> surface_interface.cpp:813
> +setOutputs(outputs);
> +}}, Qt::UniqueConnection);
> }
UniqueConnection with lambda ?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7531
To: davide
davidedmundson created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
As per existing TODO.
A new signal is added on Global to emit so we can process the result
whist
