D7487: Make KCMultiDialog scrollable

2018-08-05 Thread Nathaniel Graham
ngraham added a comment. Restricted Application added a subscriber: kde-frameworks-devel. This has caused some pain with a number of KCMs, most notably plasma-nm and kscreen, but also others too (languages, shortcuts, powerdevil, activities). See all the duplicates of https://bugs.kde.org/sho

D7487: Make KCMultiDialog scrollable

2017-09-05 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D7487 To: valeriymalov, #frameworks, davidedmundson Cc: davidedmundson, wbauer, broulik

D7487: Make KCMultiDialog scrollable

2017-09-01 Thread Valeriy Malov
valeriymalov added a comment. In https://phabricator.kde.org/D7487#141996, @davidedmundson wrote: > For some reason "kcmshell5 kscreen" looks awful. It comes up tiny. This seems to be caused by the way KScreen's KCM is initialized, probably because of QML? Window content seems to

D7487: Make KCMultiDialog scrollable

2017-09-01 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. For some reason "kcmshell5 kscreen" looks awful. It comes up tiny. Most the rest seem OK (I checked ~15) . There must be something very specific about that one. If you c

D7487: Make KCMultiDialog scrollable

2017-08-25 Thread Valeriy Malov
valeriymalov updated this revision to Diff 18774. valeriymalov edited the summary of this revision. valeriymalov added a comment. Oops, should be fixed now REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7487?vs=18616&id=18774 BRANCH master REVISION DET

D7487: Make KCMultiDialog scrollable

2017-08-25 Thread Wolfgang Bauer
wbauer added a comment. The referenced bug number seems to be wrong. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D7487 To: valeriymalov, #frameworks Cc: wbauer, broulik

D7487: Make KCMultiDialog scrollable

2017-08-23 Thread Valeriy Malov
valeriymalov updated this revision to Diff 18616. valeriymalov added a comment. Split commit in two (hopefully) REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7487?vs=18604&id=18616 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7487 AFF

D7487: Make KCMultiDialog scrollable

2017-08-23 Thread Kai Uwe Broulik
broulik added a comment. +1 but re-arrange the includes in a separate commit as it's not really related to this. System Settings has its own scroll bars anyway, so I think no KCM adds them on its own. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D7487

D7487: Make KCMultiDialog scrollable

2017-08-23 Thread Valeriy Malov
valeriymalov created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Put KCModuleProxy into a QScrollArea the same way SystemSettings does This should make kcmshell and other users of KCMultiDialog a bit more friendly to small screens However, this as