D7062: Create a designer plugin for kpasswordlineedit

2017-08-03 Thread Laurent Montel
mlaurent closed this revision. REVISION DETAIL https://phabricator.kde.org/D7062 To: mlaurent, dfaure, kossebau, cfeck Cc: cfeck, elvisangelaccio, #frameworks

D7062: Create a designer plugin for kpasswordlineedit

2017-08-03 Thread Christoph Feck
cfeck removed a reviewer: elvisangelaccio. cfeck accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D7062 To: mlaurent, dfaure, kossebau, cfeck Cc: cfeck, elvisangelaccio, #frameworks

D7062: Create a designer plugin for kpasswordlineedit

2017-08-02 Thread Laurent Montel
mlaurent marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D7062 To: mlaurent, dfaure, kossebau, elvisangelaccio Cc: cfeck, elvisangelaccio, #frameworks

D7062: Create a designer plugin for kpasswordlineedit

2017-08-02 Thread Laurent Montel
mlaurent updated this revision to Diff 17592. mlaurent added a comment. Remove empty line Move in good place. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7062?vs=17574&id=17592 REVISION DETAIL https://phabricator.kde.org/D7062 AFFECTED FILES src/kde.widgets To: mlaurent,

D7062: Create a designer plugin for kpasswordlineedit

2017-08-02 Thread Christoph Feck
cfeck added a comment. And that file looks at least a bit sorted by class name... REVISION DETAIL https://phabricator.kde.org/D7062 To: mlaurent, dfaure, kossebau, elvisangelaccio Cc: cfeck, elvisangelaccio, #frameworks

D7062: Create a designer plugin for kpasswordlineedit

2017-08-02 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > kde.widgets:327 > Group=Sonnet (KDE) > + > + Remove duplicate empty line REVISION DETAIL https://phabricator.kde.org/D7062 To: mlaurent, dfaure, kossebau, elvisangelaccio Cc: cfeck, elvisangelaccio, #frameworks

D7062: Create a designer plugin for kpasswordlineedit

2017-08-02 Thread Laurent Montel
mlaurent marked 2 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D7062 To: mlaurent, dfaure, kossebau, elvisangelaccio Cc: elvisangelaccio, #frameworks

D7062: Create a designer plugin for kpasswordlineedit

2017-08-02 Thread Laurent Montel
mlaurent updated this revision to Diff 17574. mlaurent added a comment. Fix typo + Group as requested. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7062?vs=17542&id=17574 REVISION DETAIL https://phabricator.kde.org/D7062 AFFECTED FILES src/kde.widgets To: mlaurent, dfaure, k

D7062: Create a designer plugin for kpasswordlineedit

2017-08-02 Thread Elvis Angelaccio
elvisangelaccio requested changes to this revision. elvisangelaccio added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kde.widgets:332 > +ToolTip=A Password LineEdit (KDE) > +WhatsThis=An Custom LineEdit which allows to show password > +Group=Display (KDE) Ty

D7062: Create a designer plugin for kpasswordlineedit

2017-08-02 Thread Laurent Montel
mlaurent created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY We need a plugin for showing it in designer TEST PLAN launch designer with knewpasswordwidget from kwidgetaddons REPOSITORY R298 KDesi