D6473: Crash when replacing new lines with spaces

dhaumann commandeered this revision. dhaumann edited reviewers, added: jsalatas; removed: dhaumann. dhaumann added a comment. Reassign REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: dhaumann, #ktexteditor, jsalatas Cc: kde-frameworks-devel, mwolff, antho

D6473: Crash when replacing new lines with spaces

dhaumann abandoned this revision. dhaumann added a comment. Fixed in D14847 in a different way. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: dhaumann, #ktexteditor, jsalatas Cc: kde-frameworks-devel, mwolff, anthony

D6473: Crash when replacing new lines with spaces

anthonyfieroni added a comment. I'm aware of that it will fix the crash but functionally still will be missing, but i'll give a try. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: jsalatas, #ktexteditor, dhaumann Cc: kde-frameworks-devel, mwolff, anthon

D6473: Crash when replacing new lines with spaces

dhaumann added a comment. Hm, can you send a patch that fixes this? :-) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: jsalatas, #ktexteditor, dhaumann Cc: kde-frameworks-devel, mwolff, anthonyfieroni, dhaumann, kfunk, ltoscano, kwrite-devel, michaelh,

D6473: Crash when replacing new lines with spaces

anthonyfieroni added a comment. About me when line(...) is accessed it should check for nullptr as well if (auto l = line(a)) { return l->accessor(); } https://phabricator.kde.org/source/ktexteditor/browse/master/src/render/katelayoutcache.cpp;ad51cece443bc6bb643fa4ca94

D6473: Crash when replacing new lines with spaces

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Herald added a project: Kate. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. I was just about to merge this patch. But the crash still happens for

D6473: Crash when replacing new lines with spaces

mwolff added a comment. ping? can this be merged? can a unit test be written? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: jsalatas, #ktexteditor Cc: mwolff, anthonyfieroni, dhaumann, kfunk, ltoscano, kwrite-devel, #frameworks

D6473: Crash when replacing new lines with spaces

anthonyfieroni added a comment. https://phabricator.kde.org/source/ktexteditor/browse/master/src/render/katelayoutcache.cpp;ad51cece443bc6bb643fa4ca94293a13d3c2f852$321 The problem is ```realLine >= m_renderer->doc()->lines()``` it return a nullptr. First of all https://phabricator.kde.org

D6473: Crash when replacing new lines with spaces

jsalatas added a comment. In https://phabricator.kde.org/D6473#124300, @dhaumann wrote: > So the question is: Why is the cursor not updated? If we can answer this, we may be able to either find that this patch is correct, or that the root of the real issue lies somewhere else...

D6473: Crash when replacing new lines with spaces

dhaumann added a comment. ...thining a bit more about this: What I dislike is the fact that we don't seem to understand why it crashes in the first place, right? The problem is that the cursor of the view is not updated, so it is behind the document end in an invalid line. And moving the cur

D6473: Crash when replacing new lines with spaces

dhaumann added a comment. I'm not an expert in the search code - in general your fix looks sane (had a look into the KateRegExp class). A unit test indeed would be helpful, since it will allow us to not break the search code again. REPOSITORY R39 KTextEditor REVISION DETAIL https://phab

D6473: Crash when replacing new lines with spaces

jsalatas added a comment. In https://phabricator.kde.org/D6473#124287, @kfunk wrote: > Could you add a test in e.g. autotests/src/searchbar_test.cpp? Sure! will do it later... REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: jsalatas, #ktexted

D6473: Crash when replacing new lines with spaces

kfunk added a comment. Could you add a test in e.g. autotests/src/searchbar_test.cpp? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: jsalatas, #ktexteditor Cc: kfunk, ltoscano, kwrite-devel, #frameworks

D6473: Crash when replacing new lines with spaces

jsalatas added a comment. ping? :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: jsalatas, #ktexteditor Cc: ltoscano, kwrite-devel, #frameworks

D6473: Crash when replacing new lines with spaces

jsalatas edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: jsalatas, #ktexteditor Cc: ltoscano, kwrite-devel, #frameworks

D6473: Crash when replacing new lines with spaces

ltoscano added a comment. In https://phabricator.kde.org/D6473#121145, @jsalatas wrote: > In https://phabricator.kde.org/D6473#121136, @ltoscano wrote: > > > If the review is accepted and you want to close the bug, replace > > > > Fixes bug 381080 > > https://bugs.kde.org/show_b

D6473: Crash when replacing new lines with spaces

jsalatas added a comment. In https://phabricator.kde.org/D6473#121136, @ltoscano wrote: > If the review is accepted and you want to close the bug, replace > > Fixes bug 381080 > https://bugs.kde.org/show_bug.cgi?id=381080 > > with simply > > BUG: 381080 Thanks!

D6473: Crash when replacing new lines with spaces

ltoscano added a comment. If the review is accepted and you want to close the bug, replace Fixes bug 381080 https://bugs.kde.org/show_bug.cgi?id=381080 with simply BUG: 381080 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: jsalatas, #kte

D6473: Crash when replacing new lines with spaces

jsalatas created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY Fixes bug 381080 https://bugs.kde.org/show_bug.cgi?id=381080 TEST PLAN The problem was that it looked for multiline patter