dfaure added inline comments.
INLINE COMMENTS
> davidedmundson wrote in kkeysequencewidget.cpp:778
> Should this section be using ShiftModifier? Qt::SHIFT has been masked out
qglobal.h: SHIFT = Qt::ShiftModifier
so it's the same (in case your sentence was making a difference about the t
davidedmundson added inline comments.
INLINE COMMENTS
> kkeysequencewidget.cpp:778
> if (keyQt) {
> if ((keyQt == Qt::Key_Backtab) && (d->modifierKeys & Qt::SHIFT))
> {
> keyQt = Qt::Key_Tab | d->modifierKeys;
Should this section be using ShiftModifier? Qt
dfaure closed this revision.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D6226
To: dfaure, aacid
Cc: apol, #frameworks
aacid accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R263 KXmlGui
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6226
To: dfaure, aacid
Cc: apol, #frameworks
apol added a comment.
+1 makes sense
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D6226
To: dfaure
Cc: apol, #frameworks
dfaure created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Qt supports this string representation for Qt::KeypadModifier since 5.1
but this code didn't support that modifier.
This is the easy pa
