chinmoyr added a subscriber: davidedmundson.
chinmoyr added a comment.
@davidedmundson will this revision solve the problem you mentioned
https://phabricator.kde.org/D6198. I will include the code for warning in the
job itself.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde
chinmoyr updated this revision to Diff 16738.
chinmoyr marked 4 inline comments as done.
chinmoyr edited the test plan for this revision.
chinmoyr added a comment.
In my previous revision the logic for showing warning from ioslave was
flawed. In case of deleteRecursive everything would have w
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> jobuidelegateextension.h:230
> + */
> + virtual bool askPrivilegeOpConfirmation(const QList &urls,
> PrivilegeConfType privilegeConfType) = 0;
>
chinmoyr added a dependent revision: D6383: Add KAuth support to KIO's symlink
operation.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6197
To: chinmoyr, elvisangelaccio, #frameworks
Cc: eliasp, aacid
chinmoyr updated this revision to Diff 15729.
chinmoyr marked 2 inline comments as done.
chinmoyr removed a reviewer: dfaure.
chinmoyr added a comment.
QStringLiteral -> i18n
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6197?vs=15702&id=15729
REVISION DETAIL
elvisangelaccio added a comment.
Looks good to me now, just minor issues.
INLINE COMMENTS
> file.cpp:1407-1408
> +{
> +int status = messageBox(WarningContinueCancel, warningMessage(warnId),
> QStringLiteral("Warning!"),
> +QStringLiteral("Continue"),
> QStrin
chinmoyr updated this revision to Diff 15702.
chinmoyr marked 2 inline comments as done.
chinmoyr added a comment.
Removed the ifdef. Moved the execWithElevatedPrivilege() method to
file_unix.cpp .
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6197?vs=15621&i
aacid added inline comments.
INLINE COMMENTS
> chinmoyr wrote in file.cpp:1382
> This method will be used by FileProtocol::mkdir and FileProtocol::chmod which
> are not virtual method. So when called in windows this must return false for
> the time being. So IMO ifdef or something similar is n
chinmoyr edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6197
To: chinmoyr, elvisangelaccio, #frameworks, dfaure
Cc: eliasp, aacid
chinmoyr added inline comments.
INLINE COMMENTS
> aacid wrote in file.cpp:1382
> Why is there an ifdef anyway? KAuth has at least a mac backend (no idea how
> much it works) but adding an ifdef at this level seems the wrong thing to do.
This method will be used by FileProtocol::mkdir and FilePr
chinmoyr updated this revision to Diff 15621.
chinmoyr marked 6 inline comments as done.
chinmoyr added a reviewer: dfaure.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6197?vs=15515&id=15621
REVISION DETAIL
https://phabricator.kde.org/D6197
AFFECTED FILES
eliasp added inline comments.
INLINE COMMENTS
> file.h:107
> +};
> +bool execWithRoot(const QString &action, const QString &subAction, const
> QVariant &args, PriviledgeWarning warning);
> +void endPriviledgeOp();
I find `execWithRoot()` to be a bit misleading, as the goal shouldn't
aacid added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in file.cpp:1382
> Can't this go in file_unix.cpp, without ifdefs?
Why is there an ifdef anyway? KAuth has at least a mac backend (no idea how
much it works) but adding an ifdef at this level seems the wrong thing to do.
REPO
chinmoyr updated this revision to Diff 15515.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6197?vs=15385&id=15515
REVISION DETAIL
https://phabricator.kde.org/D6197
AFFECTED FILES
autotests/kiotesthelper.h
src/core/jobuidelegateextension.h
src/ioslaves/f
elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.
If I don't enter the authentication password, after ~20 seconds I get the
"Access denied to " error. Is this some timeout in the ioslave?
INLINE COMMENTS
> file
chinmoyr edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6197
To: chinmoyr, elvisangelaccio, #frameworks
chinmoyr added a dependent revision: D6198: Add KAuth support to delete
operation.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6197
To: chinmoyr, elvisangelaccio, #frameworks
chinmoyr created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This patch adds the relevant KAuth code to file ioslave that can be used to
perform various file management operations with escalated privilege.
//execWithRoot()// : This method performs the s
18 matches
Mail list logo
