D5788: Add syntax highlighting for YANG data modeling language

This revision was automatically updated to reflect the committed changes. Closed by commit R216:fa65afb0f7c5: Add syntax highlighting for YANG data modeling language (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5788?vs=14342&id=17162#toc REPOSITORY R216 Syntax

D5788: Add syntax highlighting for YANG data modeling language

aacid added a comment. Any reason not pushed? REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D5788 To: nalvarez, #kate, jkt, dhaumann Cc: aacid, dhaumann, jkt, #frameworks

D5788: Add syntax highlighting for YANG data modeling language

nalvarez added a comment. I knew the text of RFCs was under a somewhat-restrictive license. I didn't know code snippets were explicitly excluded and BSD'd instead. We can work with that then :) REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.

D5788: Add syntax highlighting for YANG data modeling language

jkt added a comment. Re "extracting bits from the RFC", RFC 6020 says (among other things) that //"Code Components extracted from this document must include Simplified BSD License text as described in Section 4.e of the Trust Legal Provisions and are provided without warranty as described in

D5788: Add syntax highlighting for YANG data modeling language

jkt accepted this revision. jkt added a comment. Oops, sorry, I forgot to comment here. I appreciate your conversion, it works really nicely! Compared to the vim version, my QtCreator theme is not highlighting the `true` and `false` keywords in statements such as `mandatory true;`. That'

D5788: Add syntax highlighting for YANG data modeling language

nalvarez added a comment. Sorry, I don't know enough about the language to provide a meaningful test. I made these highlighting rules on request by @jkt, partly translating the .vim file and partly reading the RFC, without even understanding what the language is for. I was hoping he could pr

D5788: Add syntax highlighting for YANG data modeling language

dhaumann added a comment. @nalvarez Ping? Essentially, you're good to go. It would help, if you could add a unit test for this (autotest/input/) along with the reference data (use the script autotest/update-reference-data.sh in your build folder to update this into the src folder). REPOSITO

D5788: Add syntax highlighting for YANG data modeling language

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. The patch looks good to me. Can you please also add a unit test for this? We try to have as many highlighting unit tests as possible... The unit test highlighting file should preferably

D5788: Add syntax highlighting for YANG data modeling language

nalvarez created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Add syntax highlighting for YANG data modeling language, based on yang.vim .