This revision was automatically updated to reflect the committed changes.
Closed by commit R240:416c7e9facf9: Change default pkgconfig install path for
FreeBSD (authored by tcberner).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5766?vs=14296&id=
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
Well, for me that looks good now
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5766
To: tcberner, #freebsd, apol, kfunk
Cc: kfunk, #fr
tcberner marked an inline comment as done.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5766
To: tcberner, #freebsd, apol, kfunk
Cc: kfunk, #frameworks, #build_system
tcberner updated this revision to Diff 14296.
tcberner added a comment.
- Turn around cases of the if-clause.
- Fix cmake `matches` -> `MATCHES`.
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5766?vs=14285&id=14296
BRANCH
master
REVISION
kfunk requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5766
To: tcberner, #freebsd, apol, kfunk
Cc: kfunk, #frameworks, #build_system
kfunk added inline comments.
INLINE COMMENTS
> ECMGeneratePkgConfigFile.cmake:172
>if(EGPF_INSTALL)
> -set(ECM_PKGCONFIG_INSTALL_DIR "${EGPF_LIB_INSTALL_DIR}/pkgconfig" CACHE
> PATH "The directory where pkgconfig will be installed to.")
> +if(NOT CMAKE_SYSTEM_NAME matches "FreeBSD")
tcberner updated this revision to Diff 14285.
tcberner added a comment.
Drop space after `if`.
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5766?vs=14284&id=14285
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5766
AFFECTED
tcberner created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
FreeBSD, opposed to most other sytems, does not install pkgconfig files to
lib/pkgconfig, but to libdata/pkgconf
