D5605: Allow multiple categories with the same name

2017-05-03 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R304:36f23700babd: Allow multiple categories with the same name (authored by mart). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5605?vs=14070&id=14103 REVISION DET

D5605: Allow multiple categories with the same name

2017-05-03 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH arcpatch-D5605 REVISION DETAIL https://phabricator.kde.org/D5605 To: mart, #plasma, leinir, whiting, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, spsta

D5605: Allow multiple categories with the same name

2017-05-02 Thread Marco Martin
mart updated this revision to Diff 14070. mart added a comment. - remove empty placeholders REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5605?vs=13843&id=14070 BRANCH arcpatch-D5605 REVISION DETAIL https://phabricator.kde.org/D5605 AFFECTED FILES

D5605: Allow multiple categories with the same name

2017-04-27 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > atticaprovider.cpp:129 > qCDebug(KNEWSTUFFCORE) << "Adding category: " << category.name() > << category.displayName(); > -mCategoryMap[category.name()] = category; > +mCategoryMap.insertMulti(category.na

D5605: Allow multiple categories with the same name

2017-04-26 Thread Marco Martin
mart added a reviewer: whiting. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5605 To: mart, #plasma, leinir, whiting Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5605: Allow multiple categories with the same name

2017-04-26 Thread Marco Martin
mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY the category name was intended as a kind of unique id, this isn't true anymore, so multiple categories can have the same