D5111: Provide demo/preview for checkable menu items

anthonyfieroni removed a reviewer: anthonyfieroni. Herald added a project: Plasma. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D5111 To: rjvbb, hpereiradacosta, jriddell, zhigalin Cc: ltoscano, kde-mac, #frameworks, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesli

D5111: Provide demo/preview for checkable menu items

anthonyfieroni added a dependent revision: D8741: [kget] Fix a crash when opening the transfer history dialog. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D5111 To: rjvbb, hpereiradacosta, jriddell, zhigalin, anthonyfieroni Cc: ltoscano, kde-mac, #frameworks

D5111: Provide demo/preview for checkable menu items

anthonyfieroni removed a dependent revision: D8741: [kget] Fix a crash when opening the transfer history dialog. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D5111 To: rjvbb, hpereiradacosta, jriddell, zhigalin, anthonyfieroni Cc: ltoscano, kde-mac, #frameworks

D5111: Provide demo/preview for checkable menu items

rjvbb retitled this revision from "Provide demo/preview for checkable menu items and colour scheme comparison" to "Provide demo/preview for checkable menu items". rjvbb edited the summary of this revision. rjvbb edited the test plan for this revision. rjvbb set the repository for this revision to

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb updated this revision to Diff 15812. rjvbb added a comment. Updated for 5.10.2+ CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5111?vs=12788&id=15812 REVISION DETAIL https://phabricator.kde.org/D5111 AFFECTED FILES kstyle/demo/main.cpp kstyle/demo/oxygendemodialog.cpp

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb updated this revision to Diff 12788. rjvbb added a comment. Rebased on master; also updated the MDI page title to indicate that it has menu previews. In terms of general improvement we might consider adding a command line argument to start with a specific page. CHANGES SINCE LAST

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb added a comment. In https://phabricator.kde.org/D5111#96517, @ltoscano wrote: > Which repository is this? Oxygen? Please add it. Apologies, something must have gone wrong adding it the 1st time. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D5

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb set the repository for this revision to R113 Oxygen Theme. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D5111 To: rjvbb, jriddell, anthonyfieroni, zhigalin, hpereiradacosta Cc: ltoscano, kde-mac, #frameworks

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

ltoscano added a comment. Which repository is this? Oxygen? Please add it. REVISION DETAIL https://phabricator.kde.org/D5111 To: rjvbb, jriddell, anthonyfieroni, zhigalin, hpereiradacosta Cc: ltoscano, kde-mac, #frameworks

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb updated this revision to Diff 12666. rjvbb added a comment. Maintain Qt4 compatibility CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5111?vs=12647&id=12666 REVISION DETAIL https://phabricator.kde.org/D5111 AFFECTED FILES kstyle/demo/main.cpp kstyle/demo/oxygendemodialo

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb updated this revision to Diff 12647. rjvbb added a comment. stripped diff. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5111?vs=12644&id=12647 REVISION DETAIL https://phabricator.kde.org/D5111 AFFECTED FILES kstyle/demo/oxygendemodialog.cpp kstyle/demo/oxygendemodialo

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb added a comment. Colour scheme chooser proposition split off: https://phabricator.kde.org/D5113 REVISION DETAIL https://phabricator.kde.org/D5111 To: rjvbb, jriddell, anthonyfieroni, zhigalin, hpereiradacosta Cc: kde-mac, #frameworks

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb updated this revision to Diff 12644. rjvbb edited the summary of this revision. rjvbb added a comment. Updated, not yet split. I've kept the former left-to-right menu action as a "check here" noop action and made the distinction a bit more explicit by adding a menu section (which a

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb added a comment. Once more. Note how Oxygen renders an icon on the menu button despite me having disabled the icons-in-buttons feature in the settings. Only QtCurve seems to respect this setting for regular buttons (in dialog button boxes) nowadays. F2988220: oxydemo-oxygen-menu.p

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb added a comment. Screenshots: F2988075: oxydemo-breeze.png F2988076: oxydemo-qtcurve.png F2988077: oxydemo-oxygen.png F2988078: oxydemo-qtcurve-menu.png

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb added a comment. > - please re-add the screenshot from Review Board. (sorry I was not aware of this review request cause I was not in the list of reviewers, even though official maintainer of oxygen ...) Sorry about that, I thought you'd be a member of the Plasma group. But I had

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

hpereiradacosta added a comment. Hi, Thanks for the set of patches. in general, i am ok with the change but: - please re-add the screenshot from Review Board. (sorry I was not aware of this review request cause I was not in the list of reviewers, even though official maintainer of

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb removed a project: Plasma. rjvbb removed a subscriber: plasma-devel. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D5111 To: rjvbb, hpereiradacosta, jriddell, anthonyfieroni, zhigalin Cc: kde-mac, #frameworks

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is a continuation/transfer of https://git.reviewboard.kde.org/r/128109/ (which still has a few screenshots) There currently is no "off