ngraham added a task: T9460: Consider a more user-friendly SpinBox control.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D29534
To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D29534
To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
ngraham updated this revision to Diff 82311.
ngraham added a comment.
Implement click-and-drag (along both the X and Y axes) to modify the value
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29534?vs=82276&id=82311
BRANCH
implement-sp
ngraham edited the test plan for this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D29534
To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
ngraham updated this revision to Diff 82276.
ngraham marked 4 inline comments as done.
ngraham added a comment.
More control, less parseInt
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29534?vs=82274&id=82276
BRANCH
implement-spinbox
ngraham edited the test plan for this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D29534
To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
cblack added inline comments.
INLINE COMMENTS
> SpinBox.qml:49
> +if (wheel.angleDelta.y > 0 && control.value <= control.to) {
> +control.value = parseInt(control.value, 10) +
> control.stepSize
> +valueModified()
`control.value` is alread
ngraham updated this revision to Diff 82274.
ngraham added a comment.
Mark the value has having been modified after adjusting by scrolling
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29534?vs=82273&id=82274
BRANCH
implement-spinbox-
ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Currently adjusting the value by scrolling is not implemented. This patch
impleme