dfaure added a comment.
Yep, doing it already.
REPOSITORY
R294 KBookmarks
REVISION DETAIL
https://phabricator.kde.org/D29427
To: ahmadsamir, #frameworks, dfaure, kossebau, nicolasfella
Cc: rikmills, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
kossebau added a comment.
5.70 wants this as appended commit, no?
REPOSITORY
R294 KBookmarks
REVISION DETAIL
https://phabricator.kde.org/D29427
To: ahmadsamir, #frameworks, dfaure, kossebau, nicolasfella
Cc: rikmills, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
This revision was automatically updated to reflect the committed changes.
Closed by commit R294:8a282319bc9e: [KBookmarkMenu] Assign m_actionCollection
early to prevent crash (authored by ahmadsamir).
REPOSITORY
R294 KBookmarks
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29427?vs=
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R294 KBookmarks
BRANCH
l-bookmarkmenu-assign-actioncoll (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29427
To: ahmadsamir, #frameworks, dfaure, kossebau, nicolasfella
Cc: rikm
ahmadsamir added a reviewer: nicolasfella.
REPOSITORY
R294 KBookmarks
REVISION DETAIL
https://phabricator.kde.org/D29427
To: ahmadsamir, #frameworks, dfaure, kossebau, nicolasfella
Cc: rikmills, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
ahmadsamir added a reviewer: kossebau.
REPOSITORY
R294 KBookmarks
REVISION DETAIL
https://phabricator.kde.org/D29427
To: ahmadsamir, #frameworks, dfaure, kossebau
Cc: rikmills, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
ahmadsamir added a subscriber: rikmills.
REPOSITORY
R294 KBookmarks
REVISION DETAIL
https://phabricator.kde.org/D29427
To: ahmadsamir, #frameworks, dfaure
Cc: rikmills, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.
REVISION SUMMARY
The deprecated ctor that took a KActionCollection param called the new
ctor (that doesn't take an actionCollectio
