nicolasfella closed this revision.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D29420
To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> notifybypopup.cpp:363
> +watcher->deleteLater();
> +QDBusPendingReply reply = *watcher;
> +notifications.insert(reply.argumentAt<0>(), notifica
nicolasfella updated this revision to Diff 82237.
nicolasfella added a comment.
- Use q as parent
- Change reply type
- Use ranged-for
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29420?vs=81920&id=82237
BRANCH
geninterface
REVISION DETAIL
nicolasfella marked 3 inline comments as done.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D29420
To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
nicolasfella added inline comments.
INLINE COMMENTS
> broulik wrote in notifybypopup.cpp:115
> Previously it would accept the signal from any service which I find odd,
> though. Could you maybe check git logs to see if there was a reason for this?
> It should survive restarts anyway and the serv
broulik added inline comments.
INLINE COMMENTS
> notifybypopup.cpp:115
>
> - bool connected = QDBusConnection::sessionBus().connect(QString(), //
> from any service
> -
> QString::fromLatin1(dbusPath),
Previously it would acce
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.
REVISION SUMMARY
We already use a generated interface in kstatusnotifieritem
