D29258: Don't use notifybysnore.h on MSYS2

wojnilowicz closed this revision. wojnilowicz marked an inline comment as done. wojnilowicz added a comment. In D29258#675261 , @vonreth wrote: > It probably won't hurt Thank you. I pushed it to gitlab. REPOSITORY R289 KNotifications R

D29258: Don't use notifybysnore.h on MSYS2

vonreth accepted this revision. vonreth added a comment. This revision is now accepted and ready to land. It probably won't hurt REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29258 To: wojnilowicz, broulik, brute4s99, vonreth Cc: vonreth, kd

D29258: Don't use notifybysnore.h on MSYS2

wojnilowicz marked an inline comment as done. wojnilowicz added inline comments. INLINE COMMENTS > brute4s99 wrote in CMakeLists.txt:75 > please maintain the REQUIRED call for normal Windows builds. > You can use the OS specific build variables.. Is it ready to land now? REPOSITORY R289 KNot

D29258: Don't use notifybysnore.h on MSYS2

wojnilowicz updated this revision to Diff 83272. wojnilowicz added a comment. Qt5Network added as required REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29258?vs=81529&id=83272 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29258

D29258: Don't use notifybysnore.h on MSYS2

brute4s99 added inline comments. INLINE COMMENTS > CMakeLists.txt:75 > if (WIN32) > -find_package(LibSnoreToast REQUIRED) > -set_package_properties(LibSnoreToast PROPERTIES TYPE REQUIRED please maintain the REQUIRED call for normal Windows builds. You can use the OS specific build vari

D29258: Don't use notifybysnore.h on MSYS2

wojnilowicz marked an inline comment as done. wojnilowicz added a comment. In D29258#674669 , @vonreth wrote: > You could also just deploy the binary with msys. Thanks for the hint. I already knew that possibility. REPOSITORY R289 KNoti

D29258: Don't use notifybysnore.h on MSYS2

wojnilowicz marked an inline comment as done. wojnilowicz added a comment. Thanks for looking into that matter. In D29258#674489 , @brute4s99 wrote: > I still do not understand the utility of this patch. What do you hope to fix by this patc

D29258: Don't use notifybysnore.h on MSYS2

vonreth added a comment. You could also just deploy the binary with msys. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29258 To: wojnilowicz, broulik, brute4s99, vonreth Cc: vonreth, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29258: Don't use notifybysnore.h on MSYS2

brute4s99 added a comment. I still do not understand the utility of this patch. What do you hope to fix by this patch exactly? > SnoreToast fails to build on MSYS2 due to missing > which apparently is not available for this compiler. which compiler are you referring to here?

D29258: Don't use notifybysnore.h on MSYS2

wojnilowicz added a comment. Could anyone review my patch again? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29258 To: wojnilowicz, broulik, brute4s99, vonreth Cc: vonreth, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29258: Don't use notifybysnore.h on MSYS2

wojnilowicz added a comment. In D29258#659423 , @brute4s99 wrote: > > SnoreToast fails to build on MSYS2 due to missing > > which apparently is not available for this compiler. > > I'm sorry, missing what exactly? Missing "wrl\wrap

D29258: Don't use notifybysnore.h on MSYS2

wojnilowicz updated this revision to Diff 81529. wojnilowicz added a comment. I see. I've updated the patch. Linking to downloaded library is now possible, and there is a fallback if no library is present. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D29258: Don't use notifybysnore.h on MSYS2

vonreth requested changes to this revision. vonreth added a comment. This revision now requires changes to proceed. Well the code is header only, so gcc can use it too. Everything needed is to pull in a binary, that's not ideal but I guess its better than no notifications on Windows. REPOSI

D29258: Don't use notifybysnore.h on MSYS2

brute4s99 added a comment. > SnoreToast fails to build on MSYS2 due to missing > which apparently is not available for this compiler. I'm sorry, missing what exactly? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29258 To: wojnilowicz, broulik, brute

D29258: Don't use notifybysnore.h on MSYS2

wojnilowicz created this revision. wojnilowicz added reviewers: broulik, brute4s99. wojnilowicz added a project: Frameworks. wojnilowicz requested review of this revision. REVISION SUMMARY SnoreToast fails to build on MSYS2 due to missing which apparently is not available for this compiler.