ndavis added inline comments.
INLINE COMMENTS
> kcolorscheme.h:133
> * Number of color sets.
> + * Note: don't use this
> * @since 5.65
I think it would be good to explain the issue about enums being converted into
plain integers here so that people know why they sho
ndavis added inline comments.
INLINE COMMENTS
> kcolorscheme.h:127
> +/**
> + * Colors for header areas that thould be used both by the top
> toolbar and the titlebar titlebar.
> + * @since 5.69
- `thould`
- `titlebar titlebar`
REPOSITORY
R265 KConfigWidgets
BRANCH
mart updated this revision to Diff 81363.
mart added a comment.
call it Header
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29232?vs=81352&id=81363
BRANCH
phab/toolsSet
REVISION DETAIL
https://phabricator.kde.org/D29232
AFFECTED FILES
src/
ndavis added a comment.
I personally think it should be Header since Tools sound ambiguous and oddly
limited to anyone unfamiliar with the context behind this patch
REPOSITORY
R265 KConfigWidgets
BRANCH
phab/toolsSet
REVISION DETAIL
https://phabricator.kde.org/D29232
To: mart, #vdg,
ngraham added a task: T10201: Window titlebars.
REPOSITORY
R265 KConfigWidgets
BRANCH
phab/toolsSet
REVISION DETAIL
https://phabricator.kde.org/D29232
To: mart, #vdg, #plasma, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
cblack accepted this revision.
cblack added a comment.
This revision is now accepted and ready to land.
+1 to the approach here. I assume this would probably replace the `WM` set in
kdeglobals for all practical usage?
REPOSITORY
R265 KConfigWidgets
BRANCH
phab/toolsSet
REVISION DETAIL
mart retitled this revision from "Introduce the Tools color set" to
"[WIP][RFC]Introduce the Tools color set".
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D29232
To: mart, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
