D29175: DBus Runner: Add service property to request actions once

meven added inline comments. INLINE COMMENTS > alex wrote in dbusrunnertest.cpp:206 > The concept behind this test is, that the runner is just loaded. If the > Request-Actions-Once property is correctly implemented the actions are > requested when the plugin is initialized. That means that they

D29175: DBus Runner: Add service property to request actions once

alex added inline comments. INLINE COMMENTS > meven wrote in dbusrunnertest.cpp:206 > You should have added a QSignalSpy to check prepare was called, and another > for requestAction to check it has been called only once. The concept behind this test is, that the runner is just loaded. If the R

D29175: DBus Runner: Add service property to request actions once

meven added inline comments. INLINE COMMENTS > dbusrunnertest.cpp:204 > +// We haven't called the prepare slot, if the implementation works > +// the actions should alredy be available > +auto actions = m.actionsForMatch(fakeMatch); typo: already > dbusrunnertest.cpp:206 > +auto

D29175: DBus Runner: Add service property to request actions once

This revision was automatically updated to reflect the committed changes. Closed by commit R308:7b6222d8a10b: DBus Runner: Add service property to request actions once (authored by alex). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29175?vs=81623&id=81687

D29175: DBus Runner: Add service property to request actions once

ngraham accepted this revision. REPOSITORY R308 KRunner BRANCH request_actions_once (branched from master) REVISION DETAIL https://phabricator.kde.org/D29175 To: alex, #plasma, meven, ngraham, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29175: DBus Runner: Add service property to request actions once

alex added a dependent revision: D29320: Baloo Runner: Use X-Plasma-Request-Actions-Once property in service. REPOSITORY R308 KRunner BRANCH request_actions_once (branched from master) REVISION DETAIL https://phabricator.kde.org/D29175 To: alex, #plasma, meven, ngraham, broulik Cc: kde-f

D29175: DBus Runner: Add service property to request actions once

alex updated this revision to Diff 81623. alex added a comment. Create test REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29175?vs=81165&id=81623 BRANCH request_actions_once (branched from master) REVISION DETAIL https://phabricator.kde.org/D29175 A

D29175: DBus Runner: Add service property to request actions once

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me. Before merging, maybe you could make a diff with a few runners in plasma-workspace use it. And if you could add a test. REPOSITORY R308 KRunner BRANCH request_actio

D29175: DBus Runner: Add service property to request actions once

alex added a comment. No, they are independent. I just mentioned this to avoid confusion when debugging. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29175 To: alex, #plasma, meven, ngraham, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D29175: DBus Runner: Add service property to request actions once

meven added a comment. Is it a dependency or alternative to D29050 ? REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29175 To: alex, #plasma, meven, ngraham, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D29175: DBus Runner: Add service property to request actions once

alex created this revision. alex added reviewers: Plasma, meven, ngraham, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY With the `X-Plasma-Request-Actions-Once` property the plugin can spec