D29102: Prefer QIcon::pixmap(QWindow*, ...) overload

2020-04-22 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R242:25ce2b90dab1: Prefer QIcon::pixmap(QWindow*, ...) overload (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29102?vs=80908&id=8

D29102: Prefer QIcon::pixmap(QWindow*, ...) overload

2020-04-22 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Yeah, size is in logical pixels. Multiplying doesn't make sense. I'm sure more high DPI bugs are caused by clients trying to be clever. REPOSITORY R242 Plasma Framewo

D29102: Prefer QIcon::pixmap(QWindow*, ...) overload

2020-04-22 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It takes into account the dpi of the screen we're rendering to. Other overloads as