kossebau added a comment.
The failure which triggered this patch is that appstreamcli or one of the
things it links to (since recently?) wants to use some gsettings stuff, which
it tries to look up in the system via XDG_DATA_DIRS, as found by sitter.
See
https://build.kde.org/job/Framework
pino added a comment.
(Commented in the wrong place)
Shouldn't the test completely ignore the system location, to avoid
interferences from the system installation?
REPOSITORY
R290 KPackage
REVISION DETAIL
https://phabricator.kde.org/D29063
To: kossebau, #frameworks, mart, apol, sit
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:bb560f8dfa0a: Fix testpackage-appstream: XDG_DATA_DIRS
needs to be explicitly extended (authored by kossebau).
REPOSITORY
R290 KPackage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29063
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Looks like an improvement
REPOSITORY
R290 KPackage
BRANCH
fixXDG_DATA_DIRSextending
REVISION DETAIL
https://phabricator.kde.org/D29063
To: kossebau, #frameworks, mart, apol, sitter, bco
sitter added a comment.
Looks reasonable.
@apol thoughts?
REPOSITORY
R290 KPackage
REVISION DETAIL
https://phabricator.kde.org/D29063
To: kossebau, #frameworks, mart, apol, sitter, bcooksley
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
kossebau added a comment.
Small disadvantage of the current code is that this binds things to the value
of XDG_DATA_DIRS at "cmake" runtime, not "make test" runtime. That would need
the move of the env var setting into kpackagetoolappstreamtest.cmake I guess.
Tell if you think that is import
kossebau created this revision.
kossebau added reviewers: Frameworks, mart, apol, sitter, bcooksley.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.
REVISION SUMMARY
Setting XDG_DATA_DIRS in the ENVIRONMENT property
