D28811: Add drawer on mobile and clean code

This revision was automatically updated to reflect the committed changes. Closed by commit R264:e7645ba24570: Add drawer on mobile and clean code (authored by ognarb). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28811?vs=80229&id=81051#toc REPOSITORY R264 KApiDox CHANGES SINCE LAST

D28811: Add drawer on mobile and clean code

ochurlaud accepted this revision. ochurlaud added a comment. In D28811#649209 , @ognarb wrote: > I now generate the CSS from aether-sass. The code can be found https://invent.kde.org/websites/aether-sass/-/blob/master/css/aether-sidebar.scss. A

D28811: Add drawer on mobile and clean code

ognarb added a comment. I now generate the CSS from aether-sass. The code can be found https://invent.kde.org/websites/aether-sass/-/blob/master/css/aether-sidebar.scss. And all tree wikis are using it. @ochurlaud should I create a sysadmin request for you to get access to the repo in

D28811: Add drawer on mobile and clean code

ognarb updated this revision to Diff 80229. ognarb added a comment. - Fix typo in path - Add information about there to find the source of the css files REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28811?vs=80228&id=80229 BRANCH flex-grid REVISION D

D28811: Add drawer on mobile and clean code

ognarb updated this revision to Diff 80228. ognarb added a comment. This revision is now accepted and ready to land. - Use version from cdn REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28811?vs=80156&id=80228 BRANCH flex-grid REVISION DETAIL https:/

D28811: Add drawer on mobile and clean code

ochurlaud accepted this revision. ochurlaud added a comment. OK it's clearer: Please add somewhere that it's a generated css so that no-one tries to change it by hand and ship it REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28811 To: ognarb, cblack, ochurlau

D28811: Add drawer on mobile and clean code

ognarb added a comment. POC of sharing this code with the wikis: https://wikisandbox.kde.org/Welcome_to_KDE_TechBase REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28811 To: ognarb, cblack, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gen

D28811: Add drawer on mobile and clean code

ognarb planned changes to this revision. ognarb added a comment. In D28811#648700 , @ochurlaud wrote: > I really dislike how you close brackets in css : it's more dense and harder to read. > > You indent sometimes with 1,2 or 3 spaces: it sh

D28811: Add drawer on mobile and clean code

ochurlaud added a comment. Except these clarifications, I'm not against this change REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28811 To: ognarb, cblack, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, michaelh, ngra

D28811: Add drawer on mobile and clean code

ochurlaud requested changes to this revision. ochurlaud added a comment. This revision now requires changes to proceed. I really dislike how you close brackets in css : it's more dense and harder to read. You indent sometimes with 1,2 or 3 spaces: it should be consistent. Is it somet

D28811: Add drawer on mobile and clean code

ognarb retitled this revision from "WIP: Use CSS grid to improve layout" to "Add drawer on mobile and clean code". ognarb edited the summary of this revision. ognarb edited the test plan for this revision. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28811 To: ognarb