D28770: Avoid blocking the UI thread

sandsmark added inline comments. INLINE COMMENTS > broulik wrote in currency.cpp:57 > Can probably just use `QNetworkConfigurationManager::isOnline()`? IIRC that's less reliable (e. g. if you don't use networkmanager or connman). the whole bearer thing is a bit messy, I guess that's why it's go

D28770: Avoid blocking the UI thread

sandsmark updated this revision to Diff 80004. sandsmark marked 5 inline comments as done. sandsmark added a comment. Fixed review comments REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28770?vs=79910&id=80004 REVISION DETAIL https://phabricator

D28770: Avoid blocking the UI thread

sandsmark added a comment. In D28770#646989 , @broulik wrote: > I don't fully understand the need for a thread here. > It merely blocks because the API is synchronous and thus we create a nested eventloop. > I don't think the writing and pa

D28770: Avoid blocking the UI thread

broulik added a comment. I don't fully understand the need for a thread here. It merely blocks because the API is synchronous and thus we create a nested eventloop. I don't think the writing and parsing of the cache file is a real bottleneck here. INLINE COMMENTS > currency.cpp:57 > + >

D28770: Avoid blocking the UI thread

ngraham added inline comments. INLINE COMMENTS > currency.cpp:40 > #include > +#include > +#include Unused? > currency.cpp:884 > + > +#include "currency.moc" why? REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D28770 To: sandsmark, ngraham, #frameworks,

D28770: Avoid blocking the UI thread

sandsmark created this revision. sandsmark added reviewers: ngraham, Frameworks, broulik. sandsmark added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sandsmark requested review of this revision. REVISION SUMMARY Not entirely sure about this approach (and the stuff to