D28592: [ApplicationLauncherJob] Guard against m_pids being empty

2020-04-05 Thread Ahmad Samir
ahmadsamir abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28592 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28592: [ApplicationLauncherJob] Guard against m_pids being empty

2020-04-05 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. This, hmm, sounds wrong. Is the caller calling pid() even though the job finished with an error code? Ah, yes, indeed, in the case of KRun. Whoops. Here's my suggested fix ins

D28592: [ApplicationLauncherJob] Guard against m_pids being empty

2020-04-05 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN - 'sudo chmod a-x /usr/bin/gwenview' - Try opening a picure file from e.g. dolphin, you get an error message as expecte