This revision was automatically updated to reflect the committed changes.
Closed by commit R266:07487651e13c: Remove border from format-border-set-*
icons (authored by davidhurka).
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28561?vs=79386&id=79393
RE
ndavis accepted this revision.
ndavis added a comment.
LGTM
REPOSITORY
R266 Breeze Icons
BRANCH
simplify-format-border
REVISION DETAIL
https://phabricator.kde.org/D28561
To: davidhurka, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
davidhurka edited the summary of this revision.
REPOSITORY
R266 Breeze Icons
BRANCH
simplify-format-border
REVISION DETAIL
https://phabricator.kde.org/D28561
To: davidhurka, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
davidhurka updated this revision to Diff 79386.
davidhurka added a comment.
- Remove border elements in 22px versions of format-border-*
I would like if you accept this new patch version, to be formally correct.
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricat
ndavis added a comment.
Remove the border. I don't think it makes any sense to use different styled
borders to show a lack of borders in certain places.
REPOSITORY
R266 Breeze Icons
BRANCH
simplify-format-border
REVISION DETAIL
https://phabricator.kde.org/D28561
To: davidhurka, #vdg,
ndavis accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R266 Breeze Icons
BRANCH
simplify-format-border
REVISION DETAIL
https://phabricator.kde.org/D28561
To: davidhurka, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,
davidhurka added a comment.
There are 22px versions of these icons. They passed the auto-generation,
because they use a different approach. They have a border, but it is not in
ViewBackground, but in Text with transparency 0.1. Should I add such a border
to the 16px version, or remove it in
davidhurka edited the summary of this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D28561
To: davidhurka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
davidhurka created this revision.
davidhurka added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidhurka requested review of this revision.
REVISION SUMMARY
These icons had a kind of border in ViewBackground color, which made them
look
