This revision was automatically updated to reflect the committed changes.
Closed by commit R293:6a0be3910727: [SearchStore] Use categorized logging
(authored by bruns).
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28501?vs=79172&id=79186
REVISION DETAIL
htt
ngraham accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28501
To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,
fbampaloukas, GB_2,
bruns updated this revision to Diff 79172.
bruns added a comment.
.
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28501?vs=79108&id=79172
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28501
AFFECTED FILES
src/lib/searchstore.cpp
To: br
ngraham added inline comments.
INLINE COMMENTS
> bruns wrote in searchstore.cpp:239
> Its hardly more than reformatting.
But the commit message is about categorized logging, not reformatting. Just do
the reformatting in a separate commit, no need for review I'd say
REPOSITORY
R293 Baloo
REV
bruns marked an inline comment as done.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D28501
To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,
ngr
bruns marked an inline comment as done.
bruns added inline comments.
INLINE COMMENTS
> apol wrote in searchstore.cpp:239
> This change is not related to what the commit message describes.
Its hardly more than reformatting.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D
apol added inline comments.
INLINE COMMENTS
> searchstore.cpp:239
> else if (property == "includefolder") {
> -const QByteArray folder =
> QFile::encodeName(QFileInfo(value.toString()).canonicalFilePath());
> +const QFileInfo fi = QFileInfo(value.toString());
> +cons
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
TEST PLAN
no functional changes
REPOSITORY
R293 Baloo
BRANCH
submit
REVISION DETAIL
htt
