D28466: Added Page element

ngraham added a task: T10470: Improve the visuals of tray popups. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28466 To: niccolove, #plasma, ngraham, mart Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28466: Added Page element

This revision was automatically updated to reflect the committed changes. Closed by commit R242:8b5e09314162: Added Page element (authored by niccolove). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28466?vs=79004&id=79227 REVISION DETAIL

D28466: Added Page element

mart accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D28466 To: niccolove, #plasma, ngraham, mart Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28466: Added Page element

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM but make sure @davidedmundson or another #plasma person agrees. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETA

D28466: Added Page element

ngraham added a comment. In D28466#639018 , @niccolove wrote: > In D28466#639011 , @ngraham wrote: > > > Could you add some explanation regarding what this is for? Ideally, both in the phab patch a

D28466: Added Page element

niccolove added a comment. In D28466#639011 , @ngraham wrote: > Could you add some explanation regarding what this is for? Ideally, both in the phab patch and also inline, as API docs. > > Also shouldn't this be in PlasmaExtras? I'll

D28466: Added Page element

ngraham added a comment. Could you add some explanation regarding what this is for? Ideally, both in the phab patch and also inline, as API docs. Also shouldn't this be in PlasmaExtras? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28466 To

D28466: Added Page element

niccolove marked 2 inline comments as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28466 To: niccolove, #plasma Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28466: Added Page element

niccolove updated this revision to Diff 79004. niccolove added a comment. Used correct year and implicitWidth/Height code REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28466?vs=78994&id=79004 BRANCH master REVISION DETAIL https://p

D28466: Added Page element

davidedmundson added inline comments. INLINE COMMENTS > Page.qml:2 > +/* > + * Copyright 2016 Niccolò Venerandi > + * when did you add it? > Page.qml:24 > +T.Page { > +implicitWidth: Math.max(background ? background.implicitWidth : 0, > +(contentItem ? content

D28466: Added Page element

niccolove added a dependent revision: D28467: Converted to Page with a PlasmodHeading in the heading. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28466 To: niccolove, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, br

D28466: Added Page element

niccolove added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28466 To: niccolove, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28466: Added Page element

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY Page element was missing. I added it. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAI