broulik added a dependent revision: D28285: [ApplicationLauncherJob] Add way to
launch KServiceAction.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D28278
To: davidedmundson
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,
bruns
davidedmundson added inline comments.
INLINE COMMENTS
> broulik wrote in kprocessrunner.cpp:119
> I //think// we can still end up with a `null` `service` through
> `ApplicationLauncherJob`?
I don't think so, or at least, it would be crashing already.
The constructor with the KService::Ptr uses
davidedmundson updated this revision to Diff 78463.
davidedmundson added a comment.
rebase, fix icon
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28278?vs=78451&id=78463
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28278
AFFECTED FILES
davidedmundson marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D28278
To: davidedmundson
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,
bruns
broulik added a comment.
Lovely simplification
INLINE COMMENTS
> kprocessrunner.cpp:119
> {
> -if (service && !service->entryPath().isEmpty()
> +if (!service->entryPath().isEmpty()
> && !KDesktopFile::isAuthorizedDesktopFile(service->entryPath()))
> {
I //think// we ca
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
KProcessRunner had two code paths for if data was part of the KService
or if it was separate pars. This
