D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

ahmadsamir updated this revision to Diff 79406. ahmadsamir added a comment. Rebase REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28161?vs=78528&id=79406 BRANCH l-QRE (branched from master) REVISION DETAIL https://phabricator.kde.org/D28161 AFFECT

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R320:bc3003f77270: [kio-extras] Port some QRegExp usage to QRegularExpression (authored by ahmadsamir). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28161?vs=79406&

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH l-QRE (branched from master) REVISION DETAIL https://phabricator.kde.org/D28161 To: ahmadsamir, dfaure, sitter, apol, meven Cc: meven, kfm-devel, kde-frameworks-devel, nikolaik

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

meven added a comment. Seems good to me REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28161 To: ahmadsamir, dfaure, sitter, apol Cc: meven, kfm-devel, kde-frameworks-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Co

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

ahmadsamir added a comment. Ping. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28161 To: ahmadsamir, dfaure, sitter, apol Cc: kfm-devel, kde-frameworks-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, fever

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

ahmadsamir added a comment. In D28161#634955 , @sitter wrote: > In D28161#634951 , @ahmadsamir wrote: > > > > Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https:

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

sitter added a comment. In D28161#634951 , @ahmadsamir wrote: > > Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client > > That's confusing; but OK, I'll

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

ahmadsamir updated this revision to Diff 78528. ahmadsamir added a comment. Leave out kdsoap-ws-discovery-client, it's maintained somewhere else... REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28161?vs=78090&id=78528 BRANCH l-QRE (branched from mast

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

ahmadsamir added a comment. In D28161#634949 , @sitter wrote: > Looks good to me, not that this means much with regular expressions. The lack of tests on this stuff makes me sad :(( Unit tests are indeed useful... > Please don't touc

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

sitter added a comment. Looks good to me, not that this means much with regular expressions. The lack of tests on this stuff makes me sad :(( Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client REPOS

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

ahmadsamir added a comment. (Also could some one with more power than me clang-format this whole repo (there's a clang-format.cmake in extra-cmake-modules)? just note that some hand-formatted char* definitions blow up :)). REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.k

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: dfaure, sitter, apol. Herald added projects: Dolphin, Frameworks. Herald added a subscriber: kfm-devel. ahmadsamir requested review of this revision. TEST PLAN Showing man pages in konqueror still works REPOSITORY R320 KIO Extras