D27986: Allow providing an error message from the application

ahmadsamir added a comment. In D27986#628977 , @bcooksley wrote: > The following is notice that I intend to revert this change, along with the corresponding commits that make use of this functionality in Dr Konqi, as they cause a FTBFS on both

D27986: Allow providing an error message from the application

bcooksley added a comment. The following is notice that I intend to revert this change, along with the corresponding commits that make use of this functionality in Dr Konqi, as they cause a FTBFS on both FreeBSD and Windows which has not been addressed. This regression is over a week old at

D27986: Allow providing an error message from the application

This revision was automatically updated to reflect the committed changes. Closed by commit R285:6177c81d04a7: Allow providing an error message from the application (authored by apol). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27986?vs=77552&id=77675 REVIS

D27986: Allow providing an error message from the application

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R285 KCrash BRANCH master REVISION DETAIL https://phabricator.kde.org/D27986 To: apol, #frameworks, sitter, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, brun

D27986: Allow providing an error message from the application

sitter added a comment. Looks alright to me now. 👍 REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D27986 To: apol, #frameworks, sitter, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27986: Allow providing an error message from the application

apol updated this revision to Diff 77552. apol added a comment. nullptr REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27986?vs=77551&id=77552 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27986 AFFECTED FILES src/kcrash.cpp src/kcras

D27986: Allow providing an error message from the application

sitter added inline comments. INLINE COMMENTS > kcrash.cpp:107 > + > +static char *s_kcrashErrorMessage; > Q_GLOBAL_STATIC(KCrash::CoreConfig, s_coreConfig) Still needs to be set to nullptr. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D27986 To: apol, #frameworks,

D27986: Allow providing an error message from the application

apol updated this revision to Diff 77551. apol added a comment. cleanup REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27986?vs=77522&id=77551 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27986 AFFECTED FILES src/kcrash.cpp src/kcras

D27986: Allow providing an error message from the application

sitter added inline comments. INLINE COMMENTS > kcrash.cpp:107 > + > +static char* s_kcrashErrorMessage; > Q_GLOBAL_STATIC(KCrash::CoreConfig, s_coreConfig) - on wrong side of space needs defining to nullptr > kcrash.cpp:994 > +{ > +s_kcrashErrorMessage = qstrdup(message.toUtf8().constDat

D27986: Allow providing an error message from the application

apol updated this revision to Diff 77522. apol added a comment. Prefer char* REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27986?vs=77451&id=77522 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27986 AFFECTED FILES src/kcrash.cpp src/

D27986: Allow providing an error message from the application

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Every other static variable here is a char* so that there's no global constructor being called at application startup. Why not do the same? Just `strdup` the result of the toUtf8

D27986: Allow providing an error message from the application

sitter added a reviewer: dfaure. sitter added a subscriber: dfaure. sitter added a comment. Paging @dfaure for expert input. Is that global static qbytearray safe? Should we make it a q_global_static to comply with our library policy? Any objections to the diff? REPOSITORY R285 KCrash RE

D27986: Allow providing an error message from the application

apol updated this revision to Diff 77451. apol marked an inline comment as done. apol added a comment. We were already creating a QByteArray, just keep it instead of allocating constantly REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27986?vs=77425&id=7745

D27986: Allow providing an error message from the application

sitter added a comment. Unit test? (: I also wonder if maybe this should be lazy allocated. The vast majority of applications probably will never set it, so allocating the memory on first use should be better for the great majority of applications while making no difference for the gdb

D27986: Allow providing an error message from the application

apol created this revision. apol added reviewers: Frameworks, sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Allows us keep the message provided by QQuickWindow::sceneGraphError to later have