D27338: Provide an initial implementation for input-method-unstable-v1

apol abandoned this revision. apol added a comment. https://invent.kde.org/plasma/kwayland-server/-/merge_requests/31 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27338 To: apol, #kwin, #frameworks Cc: davidedmundson, zzag, kde-frameworks-devel, LeGast00n, cblack

D27338: Provide an initial implementation for input-method-unstable-v1

apol added a comment. Can we not have the discussion here? I added them already. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27338 To: apol, #kwin, #frameworks Cc: davidedmundson, zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27338: Provide an initial implementation for input-method-unstable-v1

zzag added a comment. In D27338#638128 , @davidedmundson wrote: > We can't just make up policy changes ad-hoc on a review request to make it different to every other class in KWayland. Heh, if we really don't want to deviate from the res

D27338: Provide an initial implementation for input-method-unstable-v1

davidedmundson added a comment. > After reading some inline comments in D28295 , I think it would be better to get rid of the nested private class thing. We won't need to use Q_DECL_HIDDEN and this is what Qt folks do. :-) We can't just make up policy

D27338: Provide an initial implementation for input-method-unstable-v1

zzag added a comment. > If it makes you happy. But we're building with opt-in export symbols, it shouldn't make much of a difference. After reading some inline comments in D28295 , I think it would be better to get rid of the nested private class thin

D27338: Provide an initial implementation for input-method-unstable-v1

zzag added inline comments. INLINE COMMENTS > inputmethod_interface.cpp:153-154 > +{ > +for (auto r : d->resourceMap()) > +d->send_commit_state(r->handle, serial); > +} I don't understand why we need `resourceMap()` here. zwp_input_method_context_v1 is not a global so I would expect

D27338: Provide an initial implementation for input-method-unstable-v1

apol updated this revision to Diff 78557. apol added a comment. vlad++ REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27338?vs=78553&id=78557 BRANCH arcpatch-D27338 REVISION DETAIL https://phabricator.kde.org/D27338 AFFECTED FILES src/server/CMake

D27338: Provide an initial implementation for input-method-unstable-v1

zzag added inline comments. INLINE COMMENTS > inputmethod_interface.cpp:128 > +{ > +wl_resource_destroy(resource->handle); > +if (resourceMap().isEmpty()) Don't call wl_resource_destroy() in foobar_destroy_resource(), it's dangerous. void zwp_input_method_context_v1_destro

D27338: Provide an initial implementation for input-method-unstable-v1

apol updated this revision to Diff 78553. apol added a comment. forgot to save the file REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27338?vs=78549&id=78553 BRANCH arcpatch-D27338 REVISION DETAIL https://phabricator.kde.org/D27338 AFFECTED FILES

D27338: Provide an initial implementation for input-method-unstable-v1

apol marked 4 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27338 To: apol, #kwin, #frameworks Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27338: Provide an initial implementation for input-method-unstable-v1

apol updated this revision to Diff 78549. apol added a comment. address comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27338?vs=78515&id=78549 BRANCH arcpatch-D27338 REVISION DETAIL https://phabricator.kde.org/D27338 AFFECTED FILES src/se

D27338: Provide an initial implementation for input-method-unstable-v1

zzag added inline comments. INLINE COMMENTS > inputmethod_interface.cpp:128-129 > +wl_resource_destroy(resource->handle); > +if (resourceMap().isEmpty()) > +q->deleteLater(); > +} Destroy `q` in zwp_input_method_context_v1_destroy_resource(). In the destructor re

D27338: Provide an initial implementation for input-method-unstable-v1

apol updated this revision to Diff 78515. apol added a comment. rebase REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27338?vs=78514&id=78515 BRANCH arcpatch-D27338 REVISION DETAIL https://phabricator.kde.org/D27338 AFFECTED FILES src/server/CMake

D27338: Provide an initial implementation for input-method-unstable-v1

apol updated this revision to Diff 78514. apol marked an inline comment as done. apol added a comment. Address comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27338?vs=78417&id=78514 BRANCH arcpatch-D27338 REVISION DETAIL https://phabricator.

D27338: Provide an initial implementation for input-method-unstable-v1

apol marked 6 inline comments as done. apol added inline comments. INLINE COMMENTS > zzag wrote in inputmethod_interface.cpp:25 > Add Q_DECL_HIDDEN. If it makes you happy. But we're building with opt-in export symbols, it shouldn't make much of a difference. > zzag wrote in inputmethod_interfa

D27338: Provide an initial implementation for input-method-unstable-v1

zzag added inline comments. INLINE COMMENTS > display.cpp:49 > +#include "inputmethod_interface.h" > + > Stray new line. Please remove it. > inputmethod_interface.cpp:25 > + > +class InputMethodContextInterface::Private : public > QtWaylandServer::zwp_input_method_context_v1 > +{ Add Q_DECL

D27338: Provide an initial implementation for input-method-unstable-v1

apol updated this revision to Diff 78417. apol added a comment. rebase REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27338?vs=75505&id=78417 BRANCH arcpatch-D27338 REVISION DETAIL https://phabricator.kde.org/D27338 AFFECTED FILES src/server/CMake

D27338: Provide an initial implementation for input-method-unstable-v1

apol added a dependent revision: D27339: Implement input methods. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27338 To: apol, #kwin, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27338: Provide an initial implementation for input-method-unstable-v1

apol created this revision. apol added reviewers: KWin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Makes it possible to implement the protocol in your favourite compositor. TEST PLAN