This revision was automatically updated to reflect the committed changes.
Closed by commit R246:6e2f32b931e3: fix segfault at exit (authored by cullmann).
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27332?vs=75536&id=75646
REVISION DETAIL
https://phabricat
vonreth accepted this revision.
vonreth added a comment.
This revision is now accepted and ready to land.
looks good but in a future version of sonnet plugins should be unloaded when
shutting down and we should properly unload stuff.
REPOSITORY
R246 Sonnet
BRANCH
arcpatch-D27332
REVISIO
cullmann added a comment.
Ok, tested on Win10 => This solves the issue.
I see no proper way to cleanup this without thinking more about how sonnet
does cache the dictionaries internally.
It just cleans up "too late" with a global static.
Given sonnet anyways will keep all stuff loa
cullmann updated this revision to Diff 75536.
cullmann added a comment.
adapt api to used QMap
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27332?vs=75534&id=75536
BRANCH
arcpatch-D27332
REVISION DETAIL
https://phabricator.kde.org/D27332
AFFECTED FI
cullmann updated this revision to Diff 75534.
cullmann added a comment.
add missing include for windows
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27332?vs=75532&id=75534
BRANCH
arcpatch-D27332
REVISION DETAIL
https://phabricator.kde.org/D27332
AF
cullmann updated this revision to Diff 75532.
cullmann added a comment.
fix argument to create spell checker
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27332?vs=75527&id=75532
BRANCH
arcpatch-D27332
REVISION DETAIL
https://phabricator.kde.org/D2733
cullmann updated this revision to Diff 75527.
cullmann added a comment.
sonnet cleanup for the dictionaries seems to be too late
try what happen if we leak them, too
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27332?vs=75516&id=75527
BRANCH
arcpat
cullmann updated this revision to Diff 75516.
cullmann added a comment.
any cleanup crashs silently
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27332?vs=75513&id=75516
BRANCH
arcpatch-D27332
REVISION DETAIL
https://phabricator.kde.org/D27332
AFFECT
cullmann updated this revision to Diff 75513.
cullmann added a comment.
de-init com after interface got released, avoids crash
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27332?vs=75497&id=75513
BRANCH
arcpatch-D27332
REVISION DETAIL
https://phabric
cullmann added a comment.
:=) I think the issue is even much smaller, I just call un-init before
release, that is wrong :/
I will quickfix that and avoid other changes (beside the extra nullptr
checks).
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D27332
To: cul
cullmann added a comment.
I played a bit with it.
No idea why I get crash reports over the store and can't see this locally.
Given the docs state one shall not do the de-init during unloading but sonnet
handles the clients/spellers via some global static that could be a reason...
REPOSITO
cullmann updated this revision to Diff 75497.
cullmann added a comment.
- skip com init/deinit
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27332?vs=75492&id=75497
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27332
AFFECTED FILES
src
cullmann added reviewers: Frameworks, vonreth.
cullmann added a comment.
See crash reports in Windows store.
For me locally, it seemed to work :/
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D27332
To: cullmann, #frameworks, vonreth
Cc: kde-frameworks-devel, LeGas
cullmann created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cullmann requested review of this revision.
REVISION SUMMARY
de-init com after release, try to better ensure we check for nullptr
see e.g. backtrace
0 sonnet_ispellc
14 matches
Mail list logo
