D27272: Add status icons: data-error, data-warning, data-information

This revision was automatically updated to reflect the committed changes. Closed by commit R266:0f841410f874: Add status icons: data-error, data-warning, data-information (authored by kossebau). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27272?vs=7542

D27272: Add status icons: data-error, data-warning, data-information

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Personally, I think emblems are fine, but I'm not going to hold up the KDevelop patch just because of that. They already existed in Papirus, the most popular 3rd party theme. The namin

D27272: Add status icons: data-error, data-warning, data-information

kossebau added a comment. @ndavis Hi, any chance this can sneak in your busy schedule the next days? :) Anyone else from the VDG who might have time to sponsor these icons to have them available with Breeze? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27272

D27272: Add status icons: data-error, data-warning, data-information

kossebau added a dependent revision: D27321: Add status icons: data-error, data-warning, data-information. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27272 To: kossebau, #vdg, ndavis Cc: #kdevelop, ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_

D27272: Add status icons: data-error, data-warning, data-information

kossebau edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27272 To: kossebau, #vdg, ndavis Cc: #kdevelop, ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27272: Add status icons: data-error, data-warning, data-information

kossebau added a comment. Icons look like this, 16x16 & 22x22 : F8096704: Screenshot_20200211_050115.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27272 To: kossebau, #vdg, ndavis Cc: #kdevelop, ngraham, davidre, k

D27272: Add status icons: data-error, data-warning, data-information

kossebau updated this revision to Diff 75429. kossebau added a comment. missing bottom aligning of warning symbol for 22 REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27272?vs=75428&id=75429 BRANCH adddatastatusicons REVISION DETAIL https://phab

D27272: Add status icons: data-error, data-warning, data-information

kossebau updated this revision to Diff 75428. kossebau added a comment. Add own data-* icons, done to best what sleeplessness and community.kde.org guides allowed me to twist together. Color-adaption works. Hardcoded #ff for the !,i,X symbols should possible see some fix, but al

D27272: Add status icons: data-error, data-warning, data-information

kossebau added a subscriber: KDevelop. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27272 To: kossebau, #vdg, ndavis Cc: #kdevelop, ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27272: Add status icons: data-error, data-warning, data-information

kossebau added a comment. Thanks for feedback, sounds good, so we are 2 already. Now curious about more opinions. Though when I said "crude hacking" I really meant it ;) So sadly nothing to seriously upload. This need some qualified icon drawing person do get the proper roundings, diagonal

D27272: Add status icons: data-error, data-warning, data-information

ngraham added a comment. Those don't look too bad. :) Wanna submit them? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27272 To: kossebau, #vdg, ndavis Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27272: Add status icons: data-error, data-warning, data-information

kossebau added a comment. To give an example what I would expect proper Breeze status icons to look like, get an idea of me doing crude hacking to turn the emblem variants into something matching the style guide for status icons: adding in-icon margins & removing the explicit contrast outli

D27272: Add status icons: data-error, data-warning, data-information

kossebau added a comment. Simply linking the emblem icons is in any case a first cheap shot. So far I am hoping for someone fluent with icon designing who could take a look at the at the rules for status icons ( https://hig.kde.org/style/icons/action_status.html ) and give the Breeze-style

D27272: Add status icons: data-error, data-warning, data-information

kossebau added a comment. Like @davidre said. Abusing emblem icons would be a not-nice hack, those icons serve a different purpose and thus also follow different rules (e.g. being able to be painted on top of complex backgrounds). We want to use icons whose names and type are semantically c

D27272: Add status icons: data-error, data-warning, data-information

davidre added a comment. In D27272#608602 , @ngraham wrote: > I think the emblem icons look great in your "After" screenshot. > > Wouldn't it be easier to have KDevelop use these emblem icons from their current names rather than symlinking th

D27272: Add status icons: data-error, data-warning, data-information

ngraham added a comment. I think the emblem icons look great in your "After" screenshot. Wouldn't it be easier to have KDevelop use these emblem icons from their current names rather than symlinking the icons you want to use to new files with different names? Semantically it seems wrong;

D27272: Add status icons: data-error, data-warning, data-information

kossebau added a comment. See how KDevelop looks like currently using the `dialog-error` & Co. icons, the icons do not really help here being uncolored and their shape driven by "dialog": F8094659: KDevelop using dialog status icons.png This is how

D27272: Add status icons: data-error, data-warning, data-information

kossebau created this revision. kossebau added reviewers: VDG, ndavis. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY These are generic icons to use to mark the status of data or other content. T