D26877: Simplify calls to whitespace() and use it in more places.

ervin added a comment. In D26877#604672 , @dfaure wrote: > I don't like it either. It doesn't "read" well. > Looking at cout or qDebug it's much more common to `[the usual stream] << [some modifier] << some more stuff`. Yep, that's wha

D26877: Simplify calls to whitespace() and use it in more places.

tcanabrava added a subscriber: ervin. tcanabrava added a comment. I like indentedStream. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26877 To: tcanabrava, dfaure, ervin Cc: ervin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: D26877: Simplify calls to whitespace() and use it in more places.

I like indentedStream. On Sun, 2 Feb 2020 at 11:36 David Faure wrote: > dfaure requested changes to this revision. > dfaure added a comment. > This revision now requires changes to proceed. View Revision > > > I don't like it either. It doesn't "read" well.

D26877: Simplify calls to whitespace() and use it in more places.

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I don't like it either. It doesn't "read" well. Looking at cout or qDebug it's much more common to `[the usual stream] << [some modifier] << some more stuff`. Maybe it can b

D26877: Simplify calls to whitespace() and use it in more places.

ervin added a comment. I'm not sure I like whitespace() returning the stream and then being used. In effect it leads to hiding the stream object making the code more terse indeed but less obvious I think. Maybe it's a question of personal taste, @dfaure any opinion? REPOSITORY R237 KConf

D26877: Simplify calls to whitespace() and use it in more places.

tcanabrava added reviewers: dfaure, ervin. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26877 To: tcanabrava, dfaure, ervin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26877: Simplify calls to whitespace() and use it in more places.

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY whitespace now returns a textStream so we don't need to stream() << whitespace() Use whitespace where we had st