D26734: Revert readEntryList() to use QRegExp::Wildcard

This revision was automatically updated to reflect the committed changes. Closed by commit R311:02ab54ea6fe8: Revert readEntryList() to use QRegExp::Wildcard (authored by ahmadsamir). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26734?vs=73808&id=73828 REVI

D26734: Revert readEntryList() to use QRegExp::Wildcard

ahmadsamir added a comment. In D26734#596420 , @dfaure wrote: > Any longer terms plan for porting away from QRegExp then? > > Or is it arguably a bug in QRegularExpression that is assumes globbing is only used for files? Qt upstream t

D26734: Revert readEntryList() to use QRegExp::Wildcard

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Any longer terms plan for porting away from QRegExp then? Or is it arguably a bug in QRegularExpression that is assumes globbing is only used for files? REPOSITORY R311 KWallet BRAN

D26734: Revert readEntryList() to use QRegExp::Wildcard

ahmadsamir updated this revision to Diff 73808. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Tweak commit message REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26734?vs=73786&id=73808 BRANCH l-fix (branched from master) R

D26734: Revert readEntryList() to use QRegExp::Wildcard

ahmadsamir added a comment. See D26205 for details. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D26734 To: ahmadsamir, #frameworks, dfaure, apol Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26734: Revert readEntryList() to use QRegExp::Wildcard

ahmadsamir updated this revision to Diff 73786. ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ahmadsamir added a comment. Tweak commit message and test plan REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D26734: Revert readEntryList() to use QRegExp::Wildcard

ahmadsamir added a comment. Another way to fix the issue, would be to pass an empty QString as the first argument to readEntryList(), in which case readEntryList() returns all the entries, and to change the behaviour of readEntryList to use a full-fledged regex pattern to use instead of supp

D26734: Revert readEntryList() to use QRegExp::Wildcard

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY The issue with QRegularExpression::wildcardToRegularExpression() is that it's more strict in its interpreta