D26652: Unbreak module imports for Python2

This revision was automatically updated to reflect the committed changes. Closed by commit R264:eae0cd8a6ed9: Unbreak module imports for Python2 (authored by kossebau). REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26652?vs=73513&id=73762 REVISION DETAIL h

D26652: Unbreak module imports for Python2

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R264 KApiDox BRANCH fixpython2support REVISION DETAIL https://phabricator.kde.org/D26652 To: kossebau, ochurlaud, cordlandwehr, davidedmundson Cc: bcooksley, awilcox, kde-frameworks-devel, k

D26652: Unbreak module imports for Python2

kossebau added a comment. Last night's run of api.kde.org generation with kapidox locally patched with this change worked again, So unless there are objections will push then latest next WE, though happy to have people give green light before :) REPOSITORY R264 KApiDox REVISION DETAIL

D26652: Unbreak module imports for Python2

kossebau updated this revision to Diff 73513. kossebau added a comment. Brown paper bag for me: if one changes code, they should also see to trigger that code, in this case passing the --depdiagram-dot-dir arg to kapidox_generate... I can confirm now in my testing on the server that th

D26652: Unbreak module imports for Python2

kossebau added a comment. For now, given @bcooksley's comment going to try some simple change to 'from kapidox.depdiagram import gvutils', this is a pattern found elsewhere in the old code. Will do a local patch to the checkout on the server and see if this has any effect on next cron job ru

D26652: Unbreak module imports for Python2

kossebau added a comment. To add to my confusion, running the unpatched version works with my local 2.7.17 python interpreter (checked with `print (sys.version)`) and worse, running things manually on api.kde.org in some test subdir also works with its 2.7.15... Now why does it fail in

D26652: Unbreak module imports for Python2

kossebau added inline comments. INLINE COMMENTS > bcooksley wrote in frameworkdb.py:39 > This probably needs to be `import gvutils from kapidox.depdiagram` otherwise > any calling code will need to be `kapidox.depdiagram.gvutils.` > instead of just `fvutils.` (unless Python3 allows something sp

D26652: Unbreak module imports for Python2

bcooksley added inline comments. INLINE COMMENTS > frameworkdb.py:39 > +else: > +import kapidox.depdiagram.gvutils > +from kapidox.depdiagram.framework import Framework This probably needs to be `import gvutils from kapidox.depdiagram` otherwise any calling code will need to be `kapidox

D26652: Unbreak module imports for Python2

kossebau added a comment. Because the very user api.kde.org right now in production still uses python2 sadly. And replacing that server with something modern is sadly not a few-hours job, still waiting for someone to spend the weeks on getting a substitution done. REPOSITORY R264 KApiDox

D26652: Unbreak module imports for Python2

awilcox added a comment. Why should Python 2 continue to be supported, after its EOL on 2020-01-01? What cases would a user be running the latest KDE release, but still have a Python 2 interpreter present as their primary/only Python interpreter? REPOSITORY R264 KApiDox REVISION DETAI

D26652: Unbreak module imports for Python2

kossebau created this revision. kossebau added reviewers: ochurlaud, cordlandwehr. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. kossebau requested review of this revision. TEST PLAN Using kapidox_generate with python3 & python