D26519: Show button respecting what is declared by KCModule

wbauer added inline comments. INLINE COMMENTS > kcmultidialog.cpp:184 > > +auto buttons = activeModule->buttons(); > + `activeModule` can be a nullptr here, as this is outside/after the `if (activeModule)`. This causes the kontact crash. Possible fix: D27433

D26519: Show button respecting what is declared by KCModule

wbauer added a comment. This change causes kontact to crash when opening its settings: https://bugs.kde.org/show_bug.cgi?id=417396 REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26519 To: bport, ervin, meven, crossi, davidedmundson Cc: wbauer, kde-frameworks-deve

D26519: Show button respecting what is declared by KCModule

This revision was automatically updated to reflect the committed changes. Closed by commit R295:f52314e6cf19: Show button respecting what is declared by KCModule (authored by bport). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26519?vs=73045&id=73494 REVI

D26519: Show button respecting what is declared by KCModule

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26519 To: bport, ervin, meven, crossi, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26519: Show button respecting what is declared by KCModule

bport updated this revision to Diff 73045. bport added a comment. Simplify code REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26519?vs=73042&id=73045 REVISION DETAIL https://phabricator.kde.org/D26519 AFFECTED FILES src/kcmultidialog.cpp To: bport,

D26519: Show button respecting what is declared by KCModule

bport added inline comments. INLINE COMMENTS > ervin wrote in kcmultidialog.cpp:217 > Well, I think I wouldn't temper with the setVisible of helpButton at all. > Just to keep the behavior in line with systemsettings and keep the old > behavior. This is not what this patch is supposed to change

D26519: Show button respecting what is declared by KCModule

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > meven wrote in kcmultidialog.cpp:217 > You can remove this line I think : no need to disable a hidden button, or > enable a visible one. Well, I think I wouldn

D26519: Show button respecting what is declared by KCModule

meven added inline comments. INLINE COMMENTS > kcmultidialog.cpp:217 > +helpButton->setVisible(buttons & KCModule::Help); > helpButton->setEnabled(activeModule->buttons() & KCModule::Help); > } You can remove this line I think : no need to disable a hidden butto

D26519: Show button respecting what is declared by KCModule

bport created this revision. bport added reviewers: ervin, meven, crossi, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26519