D26413: Hide Kuit::setupForDomain and KuitSetup from the public API

2020-01-05 Thread David Faure
dfaure abandoned this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D26413 To: dfaure, ilic Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26413: Hide Kuit::setupForDomain and KuitSetup from the public API

2020-01-04 Thread David Faure
dfaure added a comment. In D26413#587425 , @ilic wrote: > I did intended it as public API, its usage is even explained in the Programmers Guide. So for the moment I would go with D26408 . OK, feel free

D26413: Hide Kuit::setupForDomain and KuitSetup from the public API

2020-01-04 Thread Chusslove Illich
ilic added a comment. In D26413#587390 , @dfaure wrote: > Alternative approach: export it and unittest it, D26408 . > > @ilic your input would be very welcome on which approach should be taken. I don't car

D26413: Hide Kuit::setupForDomain and KuitSetup from the public API

2020-01-04 Thread David Faure
dfaure added a comment. Alternative approach: export it and unittest it, D26408 . @ilic your input would be very welcome on which approach should be taken. I don't care much personally, it's just really inconsistent right now (looks like public API, b

D26413: Hide Kuit::setupForDomain and KuitSetup from the public API

2020-01-04 Thread David Faure
dfaure created this revision. dfaure added a reviewer: ilic. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY Since setupForDomain wasn't exported, there was no way to use the KuitSetup API. So obvio