D26148: Add truncation support to FileJob

This revision was automatically updated to reflect the committed changes. Closed by commit R241:578fbf45297b: Add truncation support to FileJob (authored by feverfew). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26148?vs=72538&id=72585 REVISION DETAIL https:

D26148: Add truncation support to FileJob

feverfew added a comment. In D26148#585958 , @dfaure wrote: > In D26148#585944 , @ngraham wrote: > > > Thanks @dfaure! Would you be able to also review D26191 ?

D26148: Add truncation support to FileJob

dfaure added a comment. In D26148#585944 , @ngraham wrote: > Thanks @dfaure! Would you be able to also review D26191 ? Yes, once it has been ported to virtual_hook as well. REPOSITORY R241 KIO BRANC

D26148: Add truncation support to FileJob

ngraham added a comment. Thanks @dfaure! Would you be able to also review D26191 ? REPOSITORY R241 KIO BRANCH arcpatch-D26148 REVISION DETAIL https://phabricator.kde.org/D26148 To: feverfew, fvogt, dfaure, sitter Cc: apol, ngraham, sitter, dfaure,

D26148: Add truncation support to FileJob

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D26148 REVISION DETAIL https://phabricator.kde.org/D26148 To: feverfew, fvogt, dfaure, sitter Cc: apol, ngraham, sitter, dfaure, kde-frameworks-devel, fvogt, LeGast00n, GB_

D26148: Add truncation support to FileJob

feverfew updated this revision to Diff 72538. feverfew added a comment. Fix introduction of BIC method REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26148?vs=72180&id=72538 BRANCH arcpatch-D26148 REVISION DETAIL https://phabricator.kde.org/D26148 AFFECT

D26148: Add truncation support to FileJob

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > filejob.h:109 > + * > + * @param length the desired length to truncate to > + */ Missing @since 5.66 > filejob.h:180 > + */ > +void trunc

D26148: Add truncation support to FileJob

feverfew edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26148 To: feverfew, fvogt, dfaure, sitter Cc: apol, ngraham, sitter, dfaure, kde-frameworks-devel, fvogt, LeGast00n, GB_2, michaelh, bruns

D26148: Add truncation support to FileJob

feverfew updated this revision to Diff 72180. feverfew added a comment. Add feature to determine if protocol supports truncation REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26148?vs=71990&id=72180 BRANCH arcpatch-D26148 REVISION DETAIL https://phabrica

D26148: Add truncation support to FileJob

feverfew added a comment. In D26148#582365 , @apol wrote: > It would be interesting to explain why it's important or how it's to be used in the commit message. Done REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26

D26148: Add truncation support to FileJob

feverfew edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26148 To: feverfew, fvogt, dfaure, sitter Cc: apol, ngraham, sitter, dfaure, kde-frameworks-devel, fvogt, LeGast00n, GB_2, michaelh, bruns

D26148: Add truncation support to FileJob

feverfew edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26148 To: feverfew, fvogt, dfaure, sitter Cc: apol, ngraham, sitter, dfaure, kde-frameworks-devel, fvogt, LeGast00n, GB_2, michaelh, bruns

D26148: Add truncation support to FileJob

feverfew added a dependent revision: D26191: Add support for FileJob->truncate() in smb/sftp slaves. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26148 To: feverfew, fvogt, dfaure, sitter Cc: apol, ngraham, sitter, dfaure, kde-frameworks-devel, fvogt, LeGast00n, GB_2, m

D26148: Add truncation support to FileJob

apol added a comment. It would be interesting to explain why it's important or how it's to be used in the commit message. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26148 To: feverfew, fvogt, dfaure, sitter Cc: apol, ngraham, sitter, dfaure, kde-frameworks-devel, f

D26148: Add truncation support to FileJob

feverfew updated this revision to Diff 71990. feverfew added a comment. Add unit test for truncation REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26148?vs=71963&id=71990 BRANCH TruncateSupport REVISION DETAIL https://phabricator.kde.org/D26148 AFFECTED

D26148: Add truncation support to FileJob

feverfew created this revision. feverfew added reviewers: fvogt, dfaure, sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. feverfew requested review of this revision. REVISION SUMMARY This patch adds support for truncation for FileJob. It also impleme