D26122: Add utility text function KShell::tildeCollapse

meven added a comment. Now we have a small list of potential users of this : plasma-desktop/kcms/kfontinst/lib/Misc.cpp:391 plasma-desktop/kcms/baloo/filteredfoldermodel.cpp:50 plasma-workspace/runners/baloo/baloosearchrunner.cpp:176 plasma-workspace/libnotificationmanager/job_p.cpp:

D26122: Add utility text function KShell::tildeCollapse

This revision was automatically updated to reflect the committed changes. Closed by commit R244:94e6927d2f8c: Add utility text function KShell::tildeCollapse (authored by meven). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26122?vs=73386&id=73528 REVIS

D26122: Add utility text function KShell::tildeCollapse

meven edited the summary of this revision. REPOSITORY R244 KCoreAddons BRANCH arcpatch-D26122 REVISION DETAIL https://phabricator.kde.org/D26122 To: meven, #frameworks, broulik, ngraham, ervin, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26122: Add utility text function KShell::tildeCollapse

apol accepted this revision. apol added a comment. Looks good to me, just explain what it does on the commit message. REPOSITORY R244 KCoreAddons BRANCH arcpatch-D26122 REVISION DETAIL https://phabricator.kde.org/D26122 To: meven, #frameworks, broulik, ngraham, ervin, apol Cc: apol, k

D26122: Add utility text function KShell::tildeCollapse

meven added a comment. @apol is it ok with you ? REPOSITORY R244 KCoreAddons BRANCH arcpatch-D26122 REVISION DETAIL https://phabricator.kde.org/D26122 To: meven, #frameworks, broulik, ngraham, ervin Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26122: Add utility text function KShell::tildeCollapse

meven added a comment. In D26122#581717 , @apol wrote: > I might be missing something, explaining why it's necessary would be useful for the commit log as well as for lost reviewers like me. To reiterate. The use case is to avoid redund

D26122: Add utility text function KShell::tildeCollapse

meven updated this revision to Diff 73386. meven added a comment. Update KF5 version in @since REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26122?vs=71898&id=73386 BRANCH arcpatch-D26122 REVISION DETAIL https://phabricator.kde.org/D26122 AFFECT

D26122: Add utility text function KShell::tildeCollapse

meven added a comment. In D26122#581717 , @apol wrote: > I might be missing something, explaining why it's necessary would be useful for the commit log as well as for lost reviewers like me. I replaced my first use case by KFilePlacesMode

D26122: Add utility text function KShell::tildeCollapse

ervin accepted this revision. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D26122 To: meven, #frameworks, broulik, ngraham, ervin Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26122: Add utility text function KShell::tildeCollapse

apol added a comment. I might be missing something, explaining why it's necessary would be useful for the commit log as well as for lost reviewers like me. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D26122 To: meven, #frameworks, broulik, ng

D26122: Add utility text function KShell::tildeCollapse

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D26122 To: meven, #frameworks, broulik, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26122: Add utility text function KShell::tildeCollapse

meven created this revision. meven added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. TEST PLAN ctest REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabri