This revision was automatically updated to reflect the committed changes.
Closed by commit R293:b5c7c6b7012a: Port to QRandomGenerator (authored by
mlaurent).
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26062?vs=71829&id=71927
REVISION DETAIL
https://phabr
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
remove_qrand (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26062
To: mlaurent, dfaure
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n,
fba
mlaurent updated this revision to Diff 71829.
mlaurent added a comment.
Move QRandomGenerator::global() outside loop
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26062?vs=71699&id=71829
BRANCH
remove_qrand (branched from master)
REVISION DETAIL
https:
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> filemonitortest.cpp:197
> {
> -int index = qrand() % possibleCharacters.length();
> +int index =
> QRandomGenerator::global()->bounded(po
mlaurent added a comment.
Ping ?:)
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D26062
To: mlaurent, dfaure
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n,
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns,
mlaurent added a reviewer: dfaure.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D26062
To: mlaurent, dfaure
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n,
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns, abra
mlaurent created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
mlaurent requested review of this revision.
REVISION SUMMARY
qrand is deprecated in qt5.15
REPOSITORY
R293 Baloo
BRANCH
remove_qrand (branched from master)
REVI
