This revision was automatically updated to reflect the committed changes.
Closed by commit R302:ed86f4f37c6b: Set breeze as default theme when reading
from configuration file (authored by bport).
REPOSITORY
R302 KIconThemes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26044?vs=7195
ervin accepted this revision.
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D26044
To: bport, #plasma, ervin, crossi, ngraham
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
ngraham accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D26044
To: bport, #plasma, ervin, crossi, ngraham
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
bport marked 2 inline comments as done.
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D26044
To: bport, #plasma, ervin, crossi
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
bport updated this revision to Diff 71955.
bport added a comment.
QString to QStringLiteral
REPOSITORY
R302 KIconThemes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26044?vs=71671&id=71955
REVISION DETAIL
https://phabricator.kde.org/D26044
AFFECTED FILES
src/kiconloader.cp
apol added a comment.
LGTM otherwise
INLINE COMMENTS
> kiconloader.cpp:564
> const QString newThemeName = sharedConfig->group("Icons")
> - .readEntry("Theme",
> QString());
> + .readEntry("Theme"
bport added a dependent revision: D24846: Port kcm icons to kconfigxt.
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D26044
To: bport, #plasma, ervin, crossi
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
bport created this revision.
bport added reviewers: Plasma, ervin, crossi.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bport requested review of this revision.
REVISION SUMMARY
Icons KCM is moved to KConfigXT, default value is "breeze" and in that case
k
